[https://nvbugs/6157892] [fix] MistralCommonImageProcessor text-only path#13916
[https://nvbugs/6157892] [fix] MistralCommonImageProcessor text-only path#13916evezhier wants to merge 6 commits into
Conversation
📝 WalkthroughWalkthroughThe ChangesOptional Images Parameter
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
tensorrt_llm/_torch/models/modeling_mistral.py (1)
1-1:⚠️ Potential issue | 🟠 Major | ⚡ Quick winAdd/update NVIDIA copyright header in this modified file.
This file is modified in this PR and currently has no NVIDIA copyright header at the top.
As per coding guidelines: "All C++, Python, and other source files must contain NVIDIA copyright header with current modification year".
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tensorrt_llm/_torch/models/modeling_mistral.py` at line 1, Add or update the NVIDIA copyright header at the top of tensorrt_llm/_torch/models/modeling_mistral.py (above the existing "import copy" statement) so the modified file includes the required NVIDIA copyright header with the current modification year; insert the standard multi-line header block as used across the repo, ensuring it appears before any imports or code in the module.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tensorrt_llm/_torch/models/modeling_mistral.py`:
- Line 312: The method MistralCommonImageProcessor.__call__ uses a mutable
default parameter images=[], which can be shared across calls; change the
signature to use images=None and inside the method initialize it with images =
[] if images is None, updating any subsequent references to the parameter
accordingly (ensure no other logic depends on an empty-list default at function
definition time).
---
Outside diff comments:
In `@tensorrt_llm/_torch/models/modeling_mistral.py`:
- Line 1: Add or update the NVIDIA copyright header at the top of
tensorrt_llm/_torch/models/modeling_mistral.py (above the existing "import copy"
statement) so the modified file includes the required NVIDIA copyright header
with the current modification year; insert the standard multi-line header block
as used across the repo, ensuring it appears before any imports or code in the
module.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: bc4f39f5-2abf-48cc-803a-c421816541ae
📒 Files selected for processing (1)
tensorrt_llm/_torch/models/modeling_mistral.py
|
/bot run --disable-fail-fast |
|
PR_Github #47521 [ run ] triggered by Bot. Commit: |
|
PR_Github #47521 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #47615 [ run ] triggered by Bot. Commit: |
|
PR_Github #47615 [ run ] completed with state |
|
/bot run --post-merge |
|
/bot run --extra-stage "L0_Test-SBSA-Multi-GPU" |
|
PR_Github #47928 [ run ] triggered by Bot. Commit: |
|
PR_Github #47931 [ run ] triggered by Bot. Commit: |
|
PR_Github #47931 [ run ] completed with state
|
|
/bot run --extra-stage "GB200-4_GPUs-PyTorch-Post-Merge-1" |
|
PR_Github #47938 [ run ] triggered by Bot. Commit: |
|
PR_Github #47938 [ run ] completed with state |
Signed-off-by: Olya Kozlova <okozlova@nvidia.com>
evezhier
force-pushed
the
fix/mistral-processor
branch
from
e209560 to
6b2e6ab
Compare
|
/bot run --disable-fail-fast --extra-stage "GB200-4_GPUs-PyTorch-Post-Merge-1" |
|
PR_Github #47965 [ run ] triggered by Bot. Commit: |
|
PR_Github #47965 [ run ] completed with state
|
|
/bot run --extra-stage "GB200-4_GPUs-PyTorch-Post-Merge-1" |
|
PR_Github #48007 [ run ] triggered by Bot. Commit: |
|
PR_Github #48007 [ run ] completed with state
|
Signed-off-by: Julien Debache <jdebache@nvidia.com>
|
/bot run |
1 similar comment
|
/bot run |
|
PR_Github #48921 [ run ] triggered by Bot. Commit: |
|
PR_Github #48921 [ run ] completed with state
|
|
/bot run |
|
PR_Github #49167 [ run ] triggered by Bot. Commit: |
|
/bot run --extra-stage "GB200-4_GPUs-PyTorch-Post-Merge-1" |
1 similar comment
|
/bot run --extra-stage "GB200-4_GPUs-PyTorch-Post-Merge-1" |
|
PR_Github #49183 [ run ] triggered by Bot. Commit: |
|
PR_Github #49183 [ run ] completed with state
|
|
/bot run --extra-stage "GB200-4_GPUs-PyTorch-Post-Merge-1" |
5 participants
Summary by CodeRabbit
Description
Allows text-only path (images optional)for MistralCommonImageProcessor
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.