[None][refactor] Decouple cached prefix from KVSlice token_range#13937
Conversation
f84b368 to
f18a0d7
Compare
|
/bot run --add-multi-gpu-test --disable-fail-fast |
|
PR_Github #47525 [ run ] triggered by Bot. Commit: |
|
PR_Github #47525 [ run ] completed with state
|
f18a0d7 to
9b2bed1
Compare
|
/bot run --add-multi-gpu-test --disable-fail-fast |
Signed-off-by: Shixiaowei02 <39303645+Shixiaowei02@users.noreply.github.com>
9b2bed1 to
8926048
Compare
|
/bot run --add-multi-gpu-test --disable-fail-fast |
|
PR_Github #47551 [ run ] triggered by Bot. Commit: |
|
PR_Github #47552 [ run ] triggered by Bot. Commit: |
|
PR_Github #47551 [ run ] completed with state |
|
PR_Github #47552 [ run ] completed with state
|
|
/bot run --stage-list "DGX_B200-PyTorch-2" --disable-fail-fast |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThis PR refactors KV cache token offset derivation in a disaggregation (distributed inference) system. The receiver no longer provides explicit token offsets; instead, the sender computes block alignment offsets implicitly from block-list sizes. The cache adapter interface is refactored to report per-layer-group cached token counts with sliding-window clamping, replacing global cached-token counting. Session metadata threads ChangesKV Token Offset & Per-Layer-Group Cache Alignment
🎯 4 (Complex) | ⏱️ ~75 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Comment |
|
PR_Github #47647 [ run ] triggered by Bot. Commit: |
|
PR_Github #47647 [ run ] completed with state |
|
/bot skip --comment "CI passed in the assembled form." |
|
PR_Github #47662 [ skip ] triggered by Bot. Commit: |
|
PR_Github #47662 [ skip ] completed with state |
…DIA#13937) Signed-off-by: Shixiaowei02 <39303645+Shixiaowei02@users.noreply.github.com>
Summary by CodeRabbit
Bug Fixes
Documentation
Tests
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.