Skip to content

[https://nvbugs/6162853][chore] unwaive test#13976

Merged
galagam merged 1 commit into
NVIDIA:mainfrom
nv-auto-deploy:gagam/unwaive-6162853
May 11, 2026
Merged

[https://nvbugs/6162853][chore] unwaive test#13976
galagam merged 1 commit into
NVIDIA:mainfrom
nv-auto-deploy:gagam/unwaive-6162853

Conversation

@galagam
Copy link
Copy Markdown
Collaborator

@galagam galagam commented May 11, 2026

Summary by CodeRabbit

  • Tests
    • Removed a test waiver record.

Review Change Stack

Description

Fix merged in #13924
This PR is just unwaiving the skip

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

@galagam galagam self-assigned this May 11, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 11, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 2cef62e4-3fb2-4698-9122-52625259c2da

📥 Commits

Reviewing files that changed from the base of the PR and between 9547230 and 98bd2c3.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

This PR removes one test waiver entry from the skip list for a DeepSeek-R1-0528 model autodeploy registry accuracy test, enabling that previously waived test case to run.

Changes

Test Waiver Configuration

Layer / File(s) Summary
Waiver List Update
tests/integration/test_lists/waives.txt
Removed the waived entry for accuracy/test_llm_api_autodeploy.py::TestModelRegistryAccuracy::test_autodeploy_from_registry[deepseek-ai_DeepSeek-R1-0528-True], enabling the test to execute.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The pull request title clearly summarizes the main change: removing a test waiver/skip entry from the waives.txt file.
Description check ✅ Passed The pull request description provides essential context: references the related fix (PR #13924) and explains the purpose (unwaiving a skip). The Test Coverage section is incomplete, but the core information is present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
⚔️ Resolve merge conflicts
  • Resolve merge conflict in branch gagam/unwaive-6162853

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Comment @coderabbitai help to get the list of available commands and usage tips.

Fix merged in NVIDIA#13924

Signed-off-by: Gal Hubara Agam <96368689+galagam@users.noreply.github.com>
@galagam galagam force-pushed the gagam/unwaive-6162853 branch from 98bd2c3 to 791f6a2 Compare May 11, 2026 07:45
@galagam
Copy link
Copy Markdown
Collaborator Author

galagam commented May 11, 2026

/bot run --extra-stage "DGX_B200-8_GPUs-AutoDeploy-Post-Merge-1" --disable-fail-fast

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #47688 [ run ] triggered by Bot. Commit: 791f6a2 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #47688 [ run ] completed with state SUCCESS. Commit: 791f6a2
/LLM/main/L0_MergeRequest_PR pipeline #37584 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@galagam
Copy link
Copy Markdown
Collaborator Author

galagam commented May 11, 2026

/bot run --extra-stage "DGX_B200-8_GPUs-AutoDeploy-Post-Merge-1"

@galagam galagam enabled auto-merge (squash) May 11, 2026 13:42
@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #47747 [ run ] triggered by Bot. Commit: 791f6a2 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #47747 [ run ] completed with state SUCCESS. Commit: 791f6a2
/LLM/main/L0_MergeRequest_PR pipeline #37642 completed with status: 'SUCCESS'

CI Report

Link to invocation

@galagam galagam merged commit f3570a8 into NVIDIA:main May 11, 2026
7 checks passed
yufeiwu-nv pushed a commit to yufeiwu-nv/TensorRT-LLM that referenced this pull request May 19, 2026
Signed-off-by: Gal Hubara Agam <96368689+galagam@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants