[TRTLLM-12624][ci] Drop tensorrt_llm/llmapi/ from multi-GPU trigger list#13993
Merged
Conversation
Signed-off-by: junq <22017000+QiJune@users.noreply.github.com>
dpitman-nvda
approved these changes
May 11, 2026
Collaborator
Author
|
/bot skip --comment "trivial changes" |
Collaborator
|
PR_Github #47807 [ skip ] triggered by Bot. Commit: |
Collaborator
|
PR_Github #47807 [ skip ] completed with state |
Collaborator
Author
|
/bot skip --comment "trivial changes" |
Collaborator
|
PR_Github #47818 [ skip ] triggered by Bot. Commit: |
Collaborator
|
PR_Github #47818 [ skip ] completed with state |
yufeiwu-nv
pushed a commit
to yufeiwu-nv/TensorRT-LLM
that referenced
this pull request
May 19, 2026
…ist (NVIDIA#13993) Signed-off-by: junq <22017000+QiJune@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Narrow the multi-GPU trigger rule in
getMultiGpuFileChangedby replacing the blankettensorrt_llm/llmapi/prefix with 5 explicit files that correspond to multi-rank / multi-node / disagg orchestration entry points.The directory prefix triggered MGPU pipelines on PRs that only modified public-API surface (
llm.py,llm_args.py), parsers (reasoning_parser.py,tokenizer.py), telemetry, or single-field config defaults — none of which exercise multi-rank code paths.Measured impact (12-week window on
main, 995 commits)bd14845e094174de6bf52f4f5509264ef975d12a) was aNone → 60 sdefault-value tightening onkv_transfer_timeout_ms; L0 disagg tests transfer in ms and never reach 60 s.Files kept as explicit MGPU triggers
tensorrt_llm/llmapi/mpi_session.pytensorrt_llm/llmapi/mgmn_leader_node.pytensorrt_llm/llmapi/mgmn_worker_node.pytensorrt_llm/llmapi/disagg_utils.pytensorrt_llm/llmapi/trtllm-llmapi-launchThese 5 are touched by only 3 commits in the 12-week window, and all 3 also trigger MGPU via
executor/,pyexecutor/, orserve/. The carve-out therefore adds 0 marginal triggers in the measured window, but is retained as forward-looking insurance for the rare PR that only touches multi-rank orchestration entry points.@coderabbitai summary
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.