Skip to content

[TRTLLM-12624][ci] Drop tensorrt_llm/llmapi/ from multi-GPU trigger list#13993

Merged
QiJune merged 1 commit into
NVIDIA:mainfrom
QiJune:llmapi_mg
May 12, 2026
Merged

[TRTLLM-12624][ci] Drop tensorrt_llm/llmapi/ from multi-GPU trigger list#13993
QiJune merged 1 commit into
NVIDIA:mainfrom
QiJune:llmapi_mg

Conversation

@QiJune
Copy link
Copy Markdown
Collaborator

@QiJune QiJune commented May 11, 2026

Summary

Narrow the multi-GPU trigger rule in getMultiGpuFileChanged by replacing the blanket tensorrt_llm/llmapi/ prefix with 5 explicit files that correspond to multi-rank / multi-node / disagg orchestration entry points.

The directory prefix triggered MGPU pipelines on PRs that only modified public-API surface (llm.py, llm_args.py), parsers (reasoning_parser.py, tokenizer.py), telemetry, or single-field config defaults — none of which exercise multi-rank code paths.

Measured impact (12-week window on main, 995 commits)

Today After
MGPU pipeline triggers 365 343
Hit rate 36.7 % 34.5 %
llmapi-solo MGPU triggers (true positives) 22 (0) 0
  • 22 fewer MGPU pipeline runs per 12 weeks (~95 / year), all on the scarcest multi-GPU runner pool.
  • 0 measured missed regressions in the window. The closest candidate (bd14845e094174de6bf52f4f5509264ef975d12a) was a None → 60 s default-value tightening on kv_transfer_timeout_ms; L0 disagg tests transfer in ms and never reach 60 s.

Files kept as explicit MGPU triggers

File Role
tensorrt_llm/llmapi/mpi_session.py MPI session lifecycle, multi-rank spawn
tensorrt_llm/llmapi/mgmn_leader_node.py Multi-GPU multi-node leader role
tensorrt_llm/llmapi/mgmn_worker_node.py Multi-GPU multi-node worker role
tensorrt_llm/llmapi/disagg_utils.py Disagg serving utilities
tensorrt_llm/llmapi/trtllm-llmapi-launch Multi-rank launch script

These 5 are touched by only 3 commits in the 12-week window, and all 3 also trigger MGPU via executor/, pyexecutor/, or serve/. The carve-out therefore adds 0 marginal triggers in the measured window, but is retained as forward-looking insurance for the rare PR that only touches multi-rank orchestration entry points.

@coderabbitai summary

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: junq <22017000+QiJune@users.noreply.github.com>
@QiJune QiJune requested review from a team as code owners May 11, 2026 09:41
@QiJune QiJune requested review from dpitman-nvda and mlefeb01 May 11, 2026 09:41
@QiJune
Copy link
Copy Markdown
Collaborator Author

QiJune commented May 12, 2026

/bot skip --comment "trivial changes"

@QiJune QiJune enabled auto-merge (squash) May 12, 2026 00:52
@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #47807 [ skip ] triggered by Bot. Commit: e67e4c3 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #47807 [ skip ] completed with state FAILURE. Commit: e67e4c3

Link to invocation

@QiJune
Copy link
Copy Markdown
Collaborator Author

QiJune commented May 12, 2026

/bot skip --comment "trivial changes"

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #47818 [ skip ] triggered by Bot. Commit: e67e4c3 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #47818 [ skip ] completed with state SUCCESS. Commit: e67e4c3
Skipping testing for commit e67e4c3

Link to invocation

@QiJune QiJune merged commit afd6c7a into NVIDIA:main May 12, 2026
9 of 10 checks passed
@QiJune QiJune changed the title [TRTLLM-12153][ci] Drop tensorrt_llm/llmapi/ from multi-GPU trigger list [TRTLLM-12624][ci] Drop tensorrt_llm/llmapi/ from multi-GPU trigger list May 12, 2026
yufeiwu-nv pushed a commit to yufeiwu-nv/TensorRT-LLM that referenced this pull request May 19, 2026
…ist (NVIDIA#13993)

Signed-off-by: junq <22017000+QiJune@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants