[None][fix] fix warm up number in disagg benchmark#14041
Conversation
Signed-off-by: Chuang Zhu <111838961+chuangz0@users.noreply.github.com>
|
/bot run --disable-fail-fast |
📝 WalkthroughWalkthroughThe change updates the UCX warmup request calculation in a disaggregated benchmark submission script. The computation shifts from using world sizes to using the number of nodes multiplied by data parallelism factors derived from attention data parallelism configuration flags. ChangesUCX Warmup Request Calculation
🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
examples/disaggregated/slurm/benchmark/submit.py (1)
1-1:⚠️ Potential issue | 🟠 Major | ⚡ Quick winAdd/update the NVIDIA copyright header for this modified file.
This file was modified but does not include the required NVIDIA header with the current modification year.
As per coding guidelines:
**/*.{cpp,h,hpp,cu,cuh,py}: All C++, Python, and other source files must contain NVIDIA copyright header with current modification year.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@examples/disaggregated/slurm/benchmark/submit.py` at line 1, Add or update the NVIDIA copyright header at the top of submit.py (above the existing shebang or immediately below it) to include the required NVIDIA header text with the current modification year; ensure the header matches the project's required format for Python files and replaces or augments any existing header lines so the file complies with the codebase rule for "*.{cpp,h,hpp,cu,cuh,py}".
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@examples/disaggregated/slurm/benchmark/submit.py`:
- Line 1: Add or update the NVIDIA copyright header at the top of submit.py
(above the existing shebang or immediately below it) to include the required
NVIDIA header text with the current modification year; ensure the header matches
the project's required format for Python files and replaces or augments any
existing header lines so the file complies with the codebase rule for
"*.{cpp,h,hpp,cu,cuh,py}".
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 82b23e95-b425-4db8-8a87-604430a85836
📒 Files selected for processing (1)
examples/disaggregated/slurm/benchmark/submit.py
|
PR_Github #47936 [ run ] triggered by Bot. Commit: |
|
PR_Github #47936 [ run ] completed with state
|
2 participants
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.