[None][chore] Remove trailing spaces from module name in logger output#14122
Conversation
|
/bot run --disable-fail-fast |
📝 WalkthroughWalkthroughThe pull request removes fixed-width padding from module name prefixes in logging output. The C++ Logger's ChangesModule prefix formatting
🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@cpp/include/tensorrt_llm/common/logger.h`:
- Around line 299-310: The fallback module label used by extractModule()
contains leading spaces (e.g. " others") which, when passed to getPrefix(Level,
std::string_view) using the "%.*s" formatting, still produces unwanted
padded-looking output; change the fallback to a clean label without leading
spaces (e.g. "others") or trim leading whitespace from the module string before
calling getPrefix, so getPrefix(...) and the static inline getPrefix(Level,
std::string_view, int) receive an unpadded module name.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: b02784ad-60d2-47a5-9406-d999794e19a3
📒 Files selected for processing (2)
cpp/include/tensorrt_llm/common/logger.htensorrt_llm/logger.py
24cec58 to
29f370e
Compare
|
PR_Github #48323 [ run ] triggered by Bot. Commit: |
29f370e to
f77b3f0
Compare
|
PR_Github #48323 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #48519 [ run ] triggered by Bot. Commit: |
|
PR_Github #48519 [ run ] completed with state
|
c805055 to
f8a42ee
Compare
|
/bot run --disable-fail-fast |
|
|
|
/bot run --disable-fail-fast |
f8a42ee to
78c39d2
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #48816 [ run ] triggered by Bot. Commit: |
|
PR_Github #48816 [ run ] completed with state
|
638c7b7 to
f409001
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #48920 [ run ] triggered by Bot. Commit: |
|
PR_Github #48920 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #49026 [ run ] triggered by Bot. Commit: |
|
PR_Github #49026 [ run ] completed with state
|
Signed-off-by: nv-guomingz <137257613+nv-guomingz@users.noreply.github.com>
f409001 to
834dfa0
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #49124 [ run ] triggered by Bot. Commit: |
|
PR_Github #49124 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #49274 [ run ] triggered by Bot. Commit: |
|
PR_Github #49274 [ run ] completed with state |
The output log now displays as below
Summary by CodeRabbit