[None][fix] Warn on experimental DeepSeek-V4 base checkpoints#14299
Merged
lfr-0531 merged 2 commits intoMay 20, 2026
Conversation
Signed-off-by: Fanrong Li <lfr-0531@users.noreply.github.com>
Collaborator
Author
|
/bot run --disable-fail-fast |
Collaborator
|
PR_Github #49153 [ run ] triggered by Bot. Commit: |
Collaborator
|
PR_Github #49153 [ run ] completed with state
|
Collaborator
Author
|
/bot run --disable-fail-fast |
Collaborator
|
PR_Github #49296 [ run ] triggered by Bot. Commit: |
Barry-Delaney
approved these changes
May 20, 2026
Collaborator
|
PR_Github #49296 [ run ] completed with state |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@coderabbitai summary
Description
DeepSeek-V4 Base checkpoints currently go through the same config path as the better supported DeepSeek-V4 Instruct checkpoints, but Base support is still experimental. The Base checkpoints in
/raid/modelcan be distinguished from Instruct checkpoints by routed MoE safetensors metadata: Instruct expert tensors use the existing MXFP4/NVFP4 layouts, while Base expert tensors are not MXFP4 or NVFP4.This PR adds a small DeepSeek-V4 Base checkpoint detector that reuses the routed MoE tensor metadata check and emits a warning when users load a Base checkpoint. The warning tells users that Base support is experimental and recommends using a DeepSeek-V4 Instruct checkpoint.
Test Coverage
Added unit coverage for DeepSeek-V4 routed expert metadata detection:
Validation run locally:
PATH=/usr/bin:$PATH pre-commit run --files tensorrt_llm/_torch/model_config.py tests/unittest/_torch/test_model_config.py/usr/bin/python3.12 -m py_compile tensorrt_llm/_torch/model_config.py tests/unittest/_torch/test_model_config.pyNot run successfully:
PYTHONPATH=$PWD pytest tests/unittest/_torch/test_model_config.py -k deepseek_v4_base_checkpoint_detectionfails during test bootstrap because the local environment is missingnvtx.PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.