Skip to content

[https://nvbugs/6189918][chore] Waive test_auto_dtype_with_helix[fifo-cudagraph:with_padding-pp1tp1cp4]#14319

Merged
chienchunhung merged 1 commit into
NVIDIA:mainfrom
chienchunhung:waive-deepseekv32-helix-cudagraph-padding
May 19, 2026
Merged

[https://nvbugs/6189918][chore] Waive test_auto_dtype_with_helix[fifo-cudagraph:with_padding-pp1tp1cp4]#14319
chienchunhung merged 1 commit into
NVIDIA:mainfrom
chienchunhung:waive-deepseekv32-helix-cudagraph-padding

Conversation

@chienchunhung
Copy link
Copy Markdown
Collaborator

@chienchunhung chienchunhung commented May 19, 2026

Summary

  • Waive accuracy/test_disaggregated_serving.py::TestDeepSeekV32Exp::test_auto_dtype_with_helix[fifo-cudagraph:with_padding-pp1tp1cp4] tracked by https://nvbugspro.nvidia.com/bug/6189918.
  • Mirrors the existing waive for the sibling pp1tp2cp2 variant under the same NVBUG.

Test plan

  • pre-commit hooks pass (file-contents-sorter re-sorted; waives duplicate check passes).
  • CI confirms the waived test is skipped.

Summary by CodeRabbit

  • Tests
    • Updated test waiver configuration for improved test suite management.

Review Change Stack

…-cudagraph:with_padding-pp1tp1cp4]

Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 19, 2026

📝 Walkthrough

Walkthrough

Adds a single SKIP waiver entry to the test waiver list for the TestDeepSeekV32Exp::test_auto_dtype_with_helix test with a specific FIFO-CUDA graph configuration, linking it to the corresponding NVIDIA bug tracker.

Changes

Test waiver entry

Layer / File(s) Summary
Test waiver SKIP entry
tests/integration/test_lists/waives.txt
Inserts a SKIP waiver for TestDeepSeekV32Exp::test_auto_dtype_with_helix with fifo-cudagraph:with_padding-pp1tp1cp4 configuration, referencing nvbugs/6189918.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • NVIDIA/TensorRT-LLM#14221: Both PRs modify tests/integration/test_lists/waives.txt by adding SKIP waiver entries for accuracy/test_disaggregated_serving.py tests.
  • NVIDIA/TensorRT-LLM#14294: Both PRs add SKIP waivers for the same test case TestDeepSeekV32Exp::test_auto_dtype_with_helix with the same bug reference nvbugs/6189918.
  • NVIDIA/TensorRT-LLM#14316: Both PRs modify tests/integration/test_lists/waives.txt by adding new SKIP waiver entries for different test cases.

Suggested reviewers

  • mzweilz
  • jieli-matrix
  • StanleySun639
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly indicates a waiver addition for a specific test case with its parameter variant, directly matching the main change in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The PR description is concise and complete, clearly explaining the waiver addition, the tracking issue, and the test plan confirmation.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Collaborator

@brb-nv brb-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chienchunhung
Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "Waive a test"

@chienchunhung chienchunhung enabled auto-merge (squash) May 19, 2026 17:50
@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #49244 [ skip ] triggered by Bot. Commit: f8e0ba9 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #49244 [ skip ] completed with state SUCCESS. Commit: f8e0ba9
Skipping testing for commit f8e0ba9

Link to invocation

@chienchunhung chienchunhung merged commit f359486 into NVIDIA:main May 19, 2026
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants