[None][infra] Waive 2 failed cases for main in post-merge#14450
[None][infra] Waive 2 failed cases for main in post-merge#14450xinhe-nv wants to merge 1 commit into
Conversation
📝 WalkthroughWalkthroughThis PR adds two new test waive entries to the test-waiver list for failing accuracy test cases: ChangesTest waive list updates
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
tests/integration/test_lists/waives.txt (1)
17-17: QA list update not needed for this PR.This is a waiver-only data change in
tests/integration/test_lists/waives.txt; notests/integration/test_lists/qa/*update is required.Also applies to: 148-148
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/integration/test_lists/waives.txt` at line 17, This PR only updates the waiver file and does not require QA list changes: ensure the only edit is to tests/integration/test_lists/waives.txt (the waived entry for accuracy/test_llm_api_autodeploy.py::TestNemotronNanoV3::test_accuracy[bf16-4-trtllm]) and do not modify any files under tests/integration/test_lists/qa/*; if any QA list entries were accidentally touched, revert those changes so the waiver-only data change remains the sole diff.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@tests/integration/test_lists/waives.txt`:
- Line 17: This PR only updates the waiver file and does not require QA list
changes: ensure the only edit is to tests/integration/test_lists/waives.txt (the
waived entry for
accuracy/test_llm_api_autodeploy.py::TestNemotronNanoV3::test_accuracy[bf16-4-trtllm])
and do not modify any files under tests/integration/test_lists/qa/*; if any QA
list entries were accidentally touched, revert those changes so the waiver-only
data change remains the sole diff.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 0e053ffc-648d-46ed-8e70-a37ab62bb6ed
📒 Files selected for processing (1)
tests/integration/test_lists/waives.txt
4f9ef63 to
0d9f7c3
Compare
Bug(s): 6162618, 6185150 Requested by: qa@nvidia.com Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
0d9f7c3 to
64388e2
Compare
|
/bot run --stage-list "" |
|
PR_Github #49894 [ run ] triggered by Bot. Commit: |
|
PR_Github #49894 [ run ] completed with state |
Auto-generated Waive PR
Created by: TensorRT LLM CI Report (requested by qa@nvidia.com)
Target branch:
mainBug(s): 6189416, 6185150
Waive entries added
This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.
Summary by CodeRabbit