[None][feat] add DSV4 KV cache pool ratio config#14623
Conversation
|
/bot run |
|
PR_Github #50502 [ run ] triggered by Bot. Commit: |
4499c60 to
5bc4a09
Compare
|
PR_Github #50502 [ run ] completed with state
|
Signed-off-by: Jiagan Cheng <jiaganc@nvidia.com>
5bc4a09 to
20cdeae
Compare
Signed-off-by: Jiagan Cheng <jiaganc@nvidia.com>
|
/bot run |
|
PR_Github #50526 [ run ] triggered by Bot. Commit: |
|
PR_Github #50526 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #50591 [ run ] triggered by Bot. Commit: |
|
PR_Github #50591 [ run ] completed with state |
@coderabbitai summary
Description
Add DeepSeek-V4 KV cache configuration knobs for KV cache manager v2:
kv_cache_config.pool_ratio: user-provided initial pool ratios. When set for DSV4, this is passed to KV cache manager v2 asinitial_pool_ratioand bypasses typical-step and constraint-based initial sizing.kv_cache_config.avg_seq_len: average sequence length used by DSV4 typical-step construction. When unset, DSV4 continues to usemax_seq_len.The change also validates pool ratios, keeps the new LLM API fields out of the legacy pybind KV cache config, and adds a guard for partially constructed KV cache managers when constructor validation fails.
Test Coverage
KvCacheConfig.pool_ratioandKvCacheConfig.avg_seq_len.initial_pool_ratiooverriding typical-step and constraints.pool_ratio,avg_seq_len, andavg_seq_len > max_seq_lenvalidation.gb-nvl-081-compute02withCUDA_ARCHITECTURES=100-real.dsv4-pool-ratio-knob-jenkins-aarch64-jiaganc; TensorRT-LLM import reports1.3.0rc15.10 passed.git diff --check HEADpassed.python3 -m py_compilepassed for changed Python files and tests.PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.