[TRTLLMINF-113][infra] Add timeout protection to Setup/Initialize stages#14682
[TRTLLMINF-113][infra] Add timeout protection to Setup/Initialize stages#14682ZhanruiSunCh wants to merge 1 commit into
Conversation
|
/bot run --post-merge --disable-fail-fast |
|
PR_Github #50752 [ run ] triggered by Bot. Commit: |
|
PR_Github #50752 [ run ] completed with state
|
Add independent timeouts to prevent network flakiness from hanging the entire slurm job until the 4h kill: K8s "Setup Environment" (runLLMTestlistOnPlatformImpl): - wget artifact download + tar extract: 15 min - pip install (requirements-dev + wheel): 30 min - Overall setup stage: 45 min SLURM "Initialize Test" (runLLMTestlistWithSbatch): - wget artifact download + tar extract: 15 min - Overall initialize stage: 30 min Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: ZhanruiSunCh <184402041+ZhanruiSunCh@users.noreply.github.com>
f932683 to
ee61e44
Compare
|
/bot run |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughJenkins pipeline script adds nested timeout blocks around long-running operations in two test execution paths: SLURM sbatch initialization wraps tar download/extraction with explicit time bounds, and platform test setup environment bounds TRT-LLM extraction and Python package installation within a 45-minute setup timeout. ChangesPipeline timeout bounds
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
PR_Github #51010 [ run ] triggered by Bot. Commit: |
|
PR_Github #51010 [ run ] completed with state
|
Add independent timeouts to prevent network flakiness from hanging the entire slurm job until the 4h kill:
K8s "Setup Environment" (runLLMTestlistOnPlatformImpl):
SLURM "Initialize Test" (runLLMTestlistWithSbatch):
Coverage: 30/32 (94%) incidents resolved. 2 uncovered are Docker push TLS timeouts (different code path).
┌─────────────────────┬────────┬────────────┬────────────┬──────────┬───────────────┐
│ Timeout │ Limit │ Normal p95 │ Worst Case │ Margin │ Risk │
├─────────────────────┼────────┼────────────┼────────────┼──────────┼───────────────┤
│ wget + tar │ 15 min │ 3.7 min │ 9.2 min │ 5.8 min │ Low │
├─────────────────────┼────────┼────────────┼────────────┼──────────┼───────────────┤
│ pip install │ 30 min │ 19.1 min │ 19.2 min │ 10.8 min │ Low │
├─────────────────────┼────────┼────────────┼────────────┼──────────┼───────────────┤
│ K8s overall setup │ 45 min │ ~23 min │ ~28 min │ 17 min │ Low │
├─────────────────────┼────────┼────────────┼────────────┼──────────┼───────────────┤
│ Slurm overall setup │ 30 min │ ~13 min │ ~23 min │ 7 min │ Monitor GB200 │
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.