Skip to content

[None][chore] Update AD model list#14686

Open
tcherckez-nvidia wants to merge 3 commits into
NVIDIA:mainfrom
nv-auto-deploy:tcherckez/update-dashboard-models-list
Open

[None][chore] Update AD model list#14686
tcherckez-nvidia wants to merge 3 commits into
NVIDIA:mainfrom
nv-auto-deploy:tcherckez/update-dashboard-models-list

Conversation

@tcherckez-nvidia
Copy link
Copy Markdown
Collaborator

@tcherckez-nvidia tcherckez-nvidia commented May 28, 2026

Summary by CodeRabbit

  • Chores
    • Restructured configuration settings for CUDA graph optimization across model deployment files.
    • Updated model registry with new model entries, including Qwen3.5 MoE variants and GLM models.
    • Adjusted configurations for existing models and disabled several entries pending environment compatibility resolution.

Review Change Stack

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Yueh-Ting (eop) Chen <yuehtingc@nvidia.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 28, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: cf2cef9d-b0df-4a69-98a2-fbd9251b9ead

📥 Commits

Reviewing files that changed from the base of the PR and between e73d068 and e1f35b2.

📒 Files selected for processing (6)
  • examples/auto_deploy/model_registry/configs/granite_4.0_h_small.yaml
  • examples/auto_deploy/model_registry/configs/granite_4.0_micro.yaml
  • examples/auto_deploy/model_registry/configs/granite_4.0_tiny_preview.yaml
  • examples/auto_deploy/model_registry/configs/hunyuan_a13b_ep.yaml
  • examples/auto_deploy/model_registry/configs/qwen3Next.yaml
  • examples/auto_deploy/model_registry/models.yaml

📝 Walkthrough

Walkthrough

This PR restructures model configuration and registry files to update CUDA graph batching configuration and manage a large set of model availability and setup changes. Five model configs relocate max_batch_size under a new cuda_graph_config section. The model registry systematically disables models with documented incompatibilities, updates configurations for large models with selective sharding and layer count specifications, and introduces IR-based sharding enablement for select deployments.

Changes

CUDA Graph Configuration Restructuring

Layer / File(s) Summary
Move max_batch_size under cuda_graph_config
examples/auto_deploy/model_registry/configs/granite_4.0_h_small.yaml, granite_4.0_micro.yaml, granite_4.0_tiny_preview.yaml, hunyuan_a13b_ep.yaml, qwen3Next.yaml
Five model configuration files transition max_batch_size from top-level keys to nested entries under a new cuda_graph_config container, providing explicit control over CUDA graph batch sizing.

Model Registry Configuration Updates

Layer / File(s) Summary
Early registry model disablement and configuration
examples/auto_deploy/model_registry/models.yaml (lines 16–207)
OpenELM, Phi-4-mini, Casper Hansen AWQ, Phi-4 variants, and early Gemma/Nvidia models are commented out with documented error reasons (keyword args, import failures, CUDA assertions). NVIDIA Nemotron multimodal variants receive partial disablement with config updates to remaining DeepSeek V2.5 and Llama-3-70B entries, adding enable_sharder_ir.yaml and adjusting world_size mappings.
Large model configuration and mid-registry updates
examples/auto_deploy/model_registry/models.yaml (lines 227–343)
New Qwen/QwQ and Gemma 2 entries are activated; multiple large models (DeepSeek R1 variants, Llama-4, Nemotron super variants) receive yaml_extra updates with num_hidden_layers_5.yaml and world_size_8.yaml; NVIDIA Llama-3.1 Nemotron large variants are disabled with detailed error annotations.
Sprint model list, family variants, and IR sharding enablement
examples/auto_deploy/model_registry/models.yaml (lines 354–817)
Qwen3.5 MoE models are activated with updated yaml_extra; zai-org/GLM-5 and GLM-4.7 are added as active entries. Candidate models from Command A, Jamba, Gemma 3n, Llama-4, UI-TARS, and large VLM families are systematically disabled with error notes (NVRTC compilation, sharding path errors, missing dependencies). IR sharding is introduced via enable_sharder_ir.yaml for select NVIDIA Nemotron and DeepSeek R1 models, with corresponding config_id and yaml_extra adjustments.

🎯 3 (Moderate) | ⏱️ ~25 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is largely empty, containing only the template structure with no substantive content in the Description, Test Coverage, or implementation details sections. Provide a clear description of the changes made, explain why the updates were necessary, and list the relevant tests or validation performed for the model registry changes.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title '[None][chore] Update AD model list' is directly related to the changeset, which updates multiple model registry configuration files and the main models.yaml file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Collaborator

@galagam galagam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments, most critical one is about NVFP4.

Comment thread examples/auto_deploy/model_registry/models.yaml Outdated
Comment thread examples/auto_deploy/model_registry/models.yaml Outdated
Comment thread examples/auto_deploy/model_registry/models.yaml Outdated
Comment thread examples/auto_deploy/model_registry/models.yaml Outdated
Comment thread examples/auto_deploy/model_registry/models.yaml Outdated
@tcherckez-nvidia tcherckez-nvidia marked this pull request as draft May 28, 2026 10:29
Signed-off-by: tcherckez-nvidia <127761168+tcherckez-nvidia@users.noreply.github.com>
Signed-off-by: tcherckez-nvidia <127761168+tcherckez-nvidia@users.noreply.github.com>
@tcherckez-nvidia tcherckez-nvidia marked this pull request as ready for review May 28, 2026 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants