Draft: Qwen3-VL: support per-request mm_processor_kwargs#14702
Draft: Qwen3-VL: support per-request mm_processor_kwargs#14702aswinvisva wants to merge 1 commit into
Conversation
…trol Signed-off-by: Aswin Visva <31215515+aswinvisva@users.noreply.github.com>
|
Actionable comments posted: 0 |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThis PR adds per-request multimodal processor kwargs to the OpenAI API, enabling clients to customize video frame parameters. The request schema accepts optional ChangesPer-Request Multimodal Processor Kwargs
🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 3❌ Failed checks (3 warnings)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
It looks like the missing plumbing was from the API / serve layer, since the code in tensorrt_llm/_torch/models/modeling_qwen3vl.py already forwarded (null) mm_processor_kwargs here. Should we add tests for the code you added in here?
…trol
Summary by CodeRabbit
New Features
mm_processor_kwargsfield.Improvements
Description
Pipe
mm_processor_kwargsthrough to the HF processor for Qwen3-VL so downstream video benchmarking can effectively measure metrics w.r.t video FPS accurately.Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.