Skip to content

[None][chore] Autodeploy unwaive 5888827, 6200112#14894

Merged
suyoggupta merged 4 commits into
NVIDIA:mainfrom
nv-auto-deploy:gagam/unwaives-260603
Jun 4, 2026
Merged

[None][chore] Autodeploy unwaive 5888827, 6200112#14894
suyoggupta merged 4 commits into
NVIDIA:mainfrom
nv-auto-deploy:gagam/unwaives-260603

Conversation

@galagam
Copy link
Copy Markdown
Collaborator

@galagam galagam commented Jun 3, 2026

Summary by CodeRabbit

  • Chores
    • Cleaned up test infrastructure by removing outdated test waivers.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

- https://nvbugs/6185150 - hang does not reproduce, presumably an infra issue
- https://nvbugs/6200112 - duplicate of https://nvbugs/6157131, already fixed
- https://nvbugs/5888827 is skipped on ToT (A30 does not support FP8)

Signed-off-by: Gal Hubara Agam <96368689+galagam@users.noreply.github.com>
@galagam galagam self-assigned this Jun 3, 2026
@galagam
Copy link
Copy Markdown
Collaborator Author

galagam commented Jun 3, 2026

/bot run

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #51780 [ run ] triggered by Bot. Commit: f316b7c Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #51780 [ run ] completed with state SUCCESS. Commit: f316b7c
/LLM/main/L0_MergeRequest_PR pipeline #41144 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

Signed-off-by: Gal Hubara-Agam <96368689+galagam@users.noreply.github.com>
@galagam
Copy link
Copy Markdown
Collaborator Author

galagam commented Jun 3, 2026

/bot run

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #51832 [ run ] triggered by Bot. Commit: 849126c Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #51832 [ run ] completed with state SUCCESS. Commit: 849126c
/LLM/main/L0_MergeRequest_PR pipeline #41194 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@galagam
Copy link
Copy Markdown
Collaborator Author

galagam commented Jun 3, 2026

/bot run --stage-list "DGX_B200-4_GPUs-AutoDeploy-1, DGX_H100-4_GPUs-AutoDeploy-1"

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #51853 [ run ] triggered by Bot. Commit: 849126c Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #51853 [ run ] completed with state FAILURE. Commit: 849126c
/LLM/main/L0_MergeRequest_PR pipeline #41212 (Partly Tested) completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@galagam
Copy link
Copy Markdown
Collaborator Author

galagam commented Jun 3, 2026

/bot run --stage-list "DGX_B200-4_GPUs-AutoDeploy-1, DGX_H100-4_GPUs-AutoDeploy-1, A30-AutoDeploy-1"

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #51870 [ run ] triggered by Bot. Commit: 849126c Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #51870 [ run ] completed with state FAILURE. Commit: 849126c
/LLM/main/L0_MergeRequest_PR pipeline #41229 (Partly Tested) completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@galagam
Copy link
Copy Markdown
Collaborator Author

galagam commented Jun 3, 2026

/bot run --stage-list "DGX_B200-4_GPUs-AutoDeploy-1, DGX_H100-4_GPUs-AutoDeploy-1, A30-AutoDeploy-1" --disable-fail-fast

@galagam galagam marked this pull request as ready for review June 3, 2026 16:57
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 3, 2026

Review Change Stack

📝 Walkthrough

Walkthrough

Two test waiver entries are removed from the integration test skip list. TestNemotronNanoV3 accuracy test waivers are removed from the LLM API autodeploy test suite, and a single test_build_ad waiver is removed from the single-GPU auto-deploy smoke tests.

Changes

Test Waivers

Layer / File(s) Summary
Remove no-longer-needed test waivers
tests/integration/test_lists/waives.txt
Waiver entries for TestNemotronNanoV3::test_accuracy[...] from accuracy/test_llm_api_autodeploy.py and test_build_ad[...] from unittest/auto_deploy/singlegpu/smoke/test_ad_build_small_single.py are removed.

Possibly related PRs

  • NVIDIA/TensorRT-LLM#14854: Modifies the same waiver file to remove/adjust SKIP entries for failing test cases.
  • NVIDIA/TensorRT-LLM#14857: Edits the same waiver file to add/remove SKIP entries for the LLM API autodeploy accuracy test case.
  • NVIDIA/TensorRT-LLM#14783: Modifies the waiver list by removing/adding SKIP entries for test cases in the accuracy/auto-deploy test suite.

Suggested reviewers

  • crazydemo
  • jieli-matrix
  • LarryXFly
  • StanleySun639

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning PR description is incomplete. The title is missing, and the Description section lacks details about what the PR accomplishes and why the waivers are being removed. Add a proper PR title following the template format (e.g., [https://nvbugs/6200112][chore] Remove waived tests) and expand the Description section to explain the rationale for removing these three waiver entries.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title correctly follows the template format with [None][chore] prefix and clearly describes the main change: removing waiver entries for the specified NVBugs.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #51878 [ run ] triggered by Bot. Commit: 849126c Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #51878 [ run ] completed with state SUCCESS. Commit: 849126c
/LLM/main/L0_MergeRequest_PR pipeline #41237 (Partly Tested) completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@galagam
Copy link
Copy Markdown
Collaborator Author

galagam commented Jun 4, 2026

/bot run --stage-list "DGX_B200-4_GPUs-AutoDeploy-1, DGX_H100-4_GPUs-AutoDeploy-1, A30-AutoDeploy-1" --disable-fail-fast

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #51947 [ run ] triggered by Bot. Commit: 849126c Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #51947 [ run ] completed with state FAILURE. Commit: 849126c
/LLM/main/L0_MergeRequest_PR pipeline #41300 (Partly Tested) completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

Signed-off-by: Gal Hubara-Agam <96368689+galagam@users.noreply.github.com>
@galagam galagam changed the title [None][chore] Autodeploy unwaive 5888827, 6200112, 6185150 [None][chore] Autodeploy unwaive 5888827, 6200112 Jun 4, 2026
Signed-off-by: Gal Hubara-Agam <96368689+galagam@users.noreply.github.com>
@galagam
Copy link
Copy Markdown
Collaborator Author

galagam commented Jun 4, 2026

/bot run --stage-list "DGX_B200-4_GPUs-AutoDeploy-1, DGX_H100-4_GPUs-AutoDeploy-1, A30-AutoDeploy-1" --disable-fail-fast

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #51981 [ run ] triggered by Bot. Commit: 20b8cc8 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #51981 [ run ] completed with state SUCCESS. Commit: 20b8cc8
/LLM/main/L0_MergeRequest_PR pipeline #41330 (Partly Tested) completed with status: 'SUCCESS'

CI Report

Link to invocation

@galagam
Copy link
Copy Markdown
Collaborator Author

galagam commented Jun 4, 2026

/bot run --stage-list "DGX_B200-AutoDeploy-1"

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #52042 [ run ] triggered by Bot. Commit: 20b8cc8 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #52042 [ run ] completed with state SUCCESS. Commit: 20b8cc8
/LLM/main/L0_MergeRequest_PR pipeline #41377 (Partly Tested) completed with status: 'SUCCESS'

CI Report

Link to invocation

@galagam
Copy link
Copy Markdown
Collaborator Author

galagam commented Jun 4, 2026

/bot skip --commit "unwaive only. Ran partial pipelines to validate the unwaived tests"

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2026

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental) --high-priority]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Supports wildcard * for pattern matching (e.g., "*PerfSanity*" matches all stages containing PerfSanity). Examples: "A10-PyTorch-1, xxx", "PerfSanity". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Supports wildcard * for pattern matching. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx", --extra-stage "Post-Merge".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

--high-priority (OPTIONAL) : Run the pipeline with high priority. This option is restricted to authorized users only and will route the job to a high-priority queue.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@galagam
Copy link
Copy Markdown
Collaborator Author

galagam commented Jun 4, 2026

/bot skip --comment "unwaive only. Ran partial pipelines to validate the unwaived tests"

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #52082 [ skip ] triggered by Bot. Commit: 20b8cc8 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #52082 [ skip ] completed with state SUCCESS. Commit: 20b8cc8
Skipping testing for commit 20b8cc8

Link to invocation

@suyoggupta suyoggupta merged commit c17611c into NVIDIA:main Jun 4, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants