[None][infra] fix cbts json decode#14928
Conversation
|
/bot run |
📝 WalkthroughWalkthroughThe PR simplifies CBTS piggyback payload handling in two Groovy test infrastructure files by removing explicit UTF-8 charset specifications. The encoding operation in L0_MergeRequest.groovy and the decoding operation in L0_Test.groovy now rely on implicit platform default charset, and the StandardCharsets import is removed. ChangesCBTS Payload Character Encoding
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@jenkins/L0_MergeRequest.groovy`:
- Line 782: The base64 encoding of inputJson uses platform default charset which
can corrupt non-ASCII content; change the encoding to use UTF-8 by getting bytes
with StandardCharsets.UTF_8 when building inputJsonB64 (replace inputJson.bytes
usage), and mirror this on decode in L0_Test.groovy by constructing
cbtsInputJson with new String(cbts.cbts_input_json_b64.decodeBase64(),
StandardCharsets.UTF_8); also add/import java.nio.charset.StandardCharsets in
both files so the charset symbol is available.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 4ff1f358-3cf3-47c5-b77e-52335c607c37
📒 Files selected for processing (2)
jenkins/L0_MergeRequest.groovyjenkins/L0_Test.groovy
|
PR_Github #51943 [ run ] triggered by Bot. Commit: |
Signed-off-by: Ivy Zhang <25222398+crazydemo@users.noreply.github.com>
|
PR_Github #51943 [ run ] completed with state
|
|
/bot run --stage-list "" |
|
PR_Github #52012 [ run ] triggered by Bot. Commit: |
|
PR_Github #52012 [ run ] completed with state |
|
/bot reuse-pipeline |
|
PR_Github #52034 [ reuse-pipeline ] triggered by Bot. Commit: |
|
PR_Github #52034 [ reuse-pipeline ] completed with state |
Signed-off-by: Ivy Zhang <25222398+crazydemo@users.noreply.github.com> Signed-off-by: yufeiwu-nv <230315618+yufeiwu-nv@users.noreply.github.com>
This PR is for fixing cbts failure with:
[2026-06-02T23:46:12.311Z] CBTS failed, falling back to full run: org.jenkinsci.plugins.scriptsecurity.sandbox.RejectedAccessException: Scripts not permitted to use method java.lang.String getBytes java.nio.charset.Charset
https://prod.blsm.nvidia.com/sw-tensorrt-top-1/blue/organizations/jenkins/LLM%2Fmain%2FL0_MergeRequest_PR/detail/L0_MergeRequest_PR/41078/pipeline/22/
Summary by CodeRabbit
Release Notes
Refactor
Chores
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.