Skip to content

[None][test] Fix the ci disagg perf local submit test scope too large issue to avoid HF Model not found#14989

Merged
fredricz-20070104 merged 14 commits into
NVIDIA:mainfrom
fredricz-20070104:feature/glm_affect
Jun 5, 2026
Merged

[None][test] Fix the ci disagg perf local submit test scope too large issue to avoid HF Model not found#14989
fredricz-20070104 merged 14 commits into
NVIDIA:mainfrom
fredricz-20070104:feature/glm_affect

Conversation

@fredricz-20070104
Copy link
Copy Markdown
Collaborator

@fredricz-20070104 fredricz-20070104 commented Jun 5, 2026

Summary by CodeRabbit

  • Chores
    • Improved performance testing command construction to ensure sanity tests execute correctly.

Fix the ci disagg perf local submit test scope too large issue to avoid HF Model not found

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 5, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: a8c4d4ef-f233-4a0d-8d70-b82be21046b2

📥 Commits

Reviewing files that changed from the base of the PR and between 81e86a5 and 5398046.

📒 Files selected for processing (1)
  • jenkins/scripts/perf/local/submit.py

📝 Walkthrough

Walkthrough

The Jenkins performance test submission script is updated to explicitly include the test module path perf/test_perf_sanity.py in the pytest command string construction, ensuring the correct test file is targeted when the performance test launch script is generated.

Changes

Pytest Command Construction Fix

Layer / File(s) Summary
Pytest command test module inclusion
jenkins/scripts/perf/local/submit.py
The generate_pytest_command function now explicitly inserts perf/test_perf_sanity.py into the pytest command string, positioning it between pytest -v and --test-prefix to ensure the test module is properly targeted.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • NVIDIA/TensorRT-LLM#14952: Updates Jenkins test configuration to consolidate the separate sanity test list into core performance tests, directly corresponding to this PR's pytest command modification.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is incomplete. It only contains '@coderabbitai summary' and lacks required sections like Description, Test Coverage, and PR Checklist items from the template. Complete the PR description by adding the Description section explaining the issue and solution, Test Coverage section listing relevant tests, and completing the PR Checklist with appropriate checkboxes marked.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title follows the required format [None][test] and clearly relates to fixing a test scope issue in CI performance testing, though the description is somewhat long and could be more concise.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@fredricz-20070104
Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "skip test as just modify local submit"

@fredricz-20070104 fredricz-20070104 enabled auto-merge (squash) June 5, 2026 04:52
@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #52245 [ skip ] triggered by Bot. Commit: 5398046 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #52245 [ skip ] completed with state SUCCESS. Commit: 5398046
Skipping testing for commit 5398046

Link to invocation

@fredricz-20070104 fredricz-20070104 merged commit 45d4d54 into NVIDIA:main Jun 5, 2026
11 checks passed
fbxai pushed a commit to fbxai/TensorRT-LLM that referenced this pull request Jun 5, 2026
… issue to avoid HF Model not found (NVIDIA#14989)

Signed-off-by: FredricZ-2007 <226039983+fredricz-20070104@users.noreply.github.com>
Signed-off-by: NVFB <186336021+NVFB@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants