-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[TRTLLM-7963][fix] Several improvements of autotuning quality #9348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TRTLLM-7963][fix] Several improvements of autotuning quality #9348
Conversation
251d827 to
5a1f1b2
Compare
|
/bot run |
📝 WalkthroughWalkthroughEarly cache lookup in choose_one now retrieves is_cache_hit, best_runner_id, best_tactic, and min_time before branching. Tuning mode short-circuits and returns cached results on hit. Non-tuning code uses the pre-fetched cache state and logs cache misses without repeating the lookup. Changes
Sequence DiagramsequenceDiagram
actor Caller
participant choose_one as choose_one()
participant Cache as profiling_cache
Caller->>choose_one: invoke(inputs, config)
activate choose_one
rect rgb(230,240,255)
Note over choose_one,Cache: Early cache lookup (new)
choose_one->>Cache: lookup(key)
Cache-->>choose_one: is_cache_hit, best_runner_id, best_tactic, min_time
end
alt is_cache_hit AND tuning_mode
rect rgb(200,255,200)
Note over choose_one: Short-circuit return (new)
choose_one-->>Caller: return cached (runner, tactic)
end
else
alt tuning_mode
rect rgb(255,245,200)
Note over choose_one: Perform profiling
choose_one->>choose_one: profile candidates
choose_one-->>Caller: return profiled (runner, tactic)
end
else not tuning_mode
rect rgb(255,230,230)
Note over choose_one: Use pre-fetched cache state
choose_one->>choose_one: use cached values or fallback
choose_one-->>Caller: return selected (runner, tactic)
end
end
end
deactivate choose_one
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
PR_Github #25282 [ run ] triggered by Bot. Commit: |
|
PR_Github #25282 [ run ] completed with state |
cbecf66 to
0306cc1
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #25290 [ run ] triggered by Bot. Commit: |
|
PR_Github #25290 [ run ] completed with state |
0306cc1 to
c0b4079
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #25302 [ run ] triggered by Bot. Commit: |
|
PR_Github #25302 [ run ] completed with state |
…avoid the host overhead. This PR skips the shape profile generating process if the profile has already been found in the cache under tuning mode. This is a prerequisite for nested autotuning. Because host overhead might be included during the profiling process of the high-level op. Signed-off-by: Yukun He <23156053+hyukn@users.noreply.github.com>
Signed-off-by: Yukun He <23156053+hyukn@users.noreply.github.com>
…s long enough time to complete. Signed-off-by: Yukun He <23156053+hyukn@users.noreply.github.com>
c0b4079 to
d2de147
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #25333 [ run ] triggered by Bot. Commit: |
|
PR_Github #25333 [ run ] completed with state |
This PR skips the shape profile generating process if the profile has already been found in the cache under tuning mode.
This is a prerequisite for nested autotuning because host overhead might be included during the profiling process of the high-level op.
Also, this PR:
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.