Skip to content

Conversation

@xinhe-nv
Copy link
Collaborator

@xinhe-nv xinhe-nv commented Dec 11, 2025

Summary by CodeRabbit

Release Notes

✏️ Tip: You can customize this high-level summary in your review settings.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@xinhe-nv xinhe-nv force-pushed the add-kimi-tests branch 6 times, most recently from 3bcc05f to b29c6ae Compare December 15, 2025 06:11
@xinhe-nv xinhe-nv marked this pull request as ready for review December 15, 2025 06:20
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 15, 2025

📝 Walkthrough

Walkthrough

These changes add support for the Kimi-K2-Thinking model with NVFP4 quantization to the test suite. Accuracy reference data is updated for GSM8K and MMLU benchmarks. A new test method is added for NVFP4 quantization testing, and test lists are updated to include the new test variants while removing legacy model configurations.

Changes

Cohort / File(s) Summary
Accuracy Reference Data
tests/integration/defs/accuracy/references/gsm8k.yaml, tests/integration/defs/accuracy/references/mmlu.yaml
Added accuracy entries for moonshotai/Kimi-K2-Thinking with NVFP4 quantization and FP8 kv_cache. Updated existing nvidia/Llama-3_3-Nemotron-Super-49B-v1 entries with nested quantization configuration objects and modified accuracy values.
Test Implementation
tests/integration/defs/accuracy/test_llm_api_pytorch.py, tests/integration/defs/test_e2e.py
Added new test_nvfp4 method to TestKimiK2 class for NVFP4 quantization validation. Replaced Kimi-K2-Instruct parameterized test entry with Kimi-K2-Thinking-NVFP4. Removed llm_venv parameter from test_multi_nodes_eval function signature.
Test List Updates
tests/integration/test_lists/qa/llm_function_core.txt, tests/integration/test_lists/qa/llm_function_core_sanity.txt, tests/integration/test_lists/qa/llm_function_multinode.txt
Removed BF16 test for Qwen3_8B. Added NVFP4 test entries for Kimi-K2-Thinking across 4 and 8 GPU configurations. Updated multinode test entry to target new Kimi-K2-Thinking-NVFP4 variant.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Potential focus areas:
    • Verify consistency between accuracy reference values in YAML files and expected test results
    • Confirm that test method test_nvfp4 implementation aligns with existing NVFP4 test patterns in the same file
    • Ensure test list entries (llm_function_*.txt) accurately reflect the new test methods and removed tests
    • Validate that removal of llm_venv parameter from test_multi_nodes_eval does not break dependency resolution in the test infrastructure

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Description check ⚠️ Warning The PR description is incomplete and lacks required sections. The description, test coverage, and PR checklist sections are empty or contain only template placeholders and GitHub bot help instructions. Fill in the Description section explaining what changes were made and why. Complete the Test Coverage section listing relevant tests. Ensure all applicable checklist items are properly reviewed and marked. Remove or properly complete the GitHub bot help section.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: adding FP4 quantization tests for the Kimi K2 model, which aligns with the actual changes adding test_nvfp4 method and related test entries.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@xinhe-nv xinhe-nv force-pushed the add-kimi-tests branch 5 times, most recently from d0c9590 to a6986e7 Compare December 16, 2025 02:28
@xinhe-nv
Copy link
Collaborator Author

/bot reuse-pipeline

@xinhe-nv xinhe-nv enabled auto-merge (squash) December 16, 2025 07:11
@tensorrt-cicd
Copy link
Collaborator

PR_Github #28531 [ reuse-pipeline ] triggered by Bot. Commit: 3a68e99

@tensorrt-cicd
Copy link
Collaborator

PR_Github #28531 [ reuse-pipeline ] completed with state SUCCESS. Commit: 3a68e99
Can't reuse PR_Github #0 with status: UNKNOWN

@xinhe-nv
Copy link
Collaborator Author

/bot run --skip-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #28534 [ run ] triggered by Bot. Commit: 3a68e99

@xinhe-nv xinhe-nv force-pushed the add-kimi-tests branch 2 times, most recently from 34ffd8a to 6c81704 Compare December 16, 2025 09:10
@tensorrt-cicd
Copy link
Collaborator

PR_Github #28534 [ run ] completed with state FAILURE. Commit: 3a68e99
/LLM/main/L0_MergeRequest_PR pipeline #21853 (Partly Tested) completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@xinhe-nv
Copy link
Collaborator Author

/bot run --skip-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #28557 [ run ] triggered by Bot. Commit: 6c81704

@tensorrt-cicd
Copy link
Collaborator

PR_Github #28557 [ run ] completed with state FAILURE. Commit: 6c81704
/LLM/main/L0_MergeRequest_PR pipeline #21875 (Partly Tested) completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@xinhe-nv xinhe-nv force-pushed the add-kimi-tests branch 2 times, most recently from 39694c7 to 1b3a03a Compare December 17, 2025 01:47
@xinhe-nv
Copy link
Collaborator Author

/bot run --skip-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #28647 [ run ] triggered by Bot. Commit: 1b3a03a

@tensorrt-cicd
Copy link
Collaborator

PR_Github #28647 [ run ] completed with state DISABLED
CI server is currently disabled for scheduled maintenance. Estimated completion time: 1 PM PST on 12/16.

@xinhe-nv
Copy link
Collaborator Author

/bot run --skip-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #28717 [ run ] triggered by Bot. Commit: 65166b0

@tensorrt-cicd
Copy link
Collaborator

PR_Github #28717 [ run ] completed with state SUCCESS. Commit: 65166b0
/LLM/main/L0_MergeRequest_PR pipeline #21967 (Partly Tested) completed with status: 'SUCCESS'

Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
@xinhe-nv
Copy link
Collaborator Author

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #28860 [ reuse-pipeline ] triggered by Bot. Commit: 6e2e5aa

@tensorrt-cicd
Copy link
Collaborator

PR_Github #28860 [ reuse-pipeline ] completed with state SUCCESS. Commit: 6e2e5aa
Reusing PR_Github #28717 (Partly Tested) for commit 6e2e5aa

@xinhe-nv xinhe-nv merged commit c1cfb61 into NVIDIA:main Dec 18, 2025
5 checks passed
@xinhe-nv xinhe-nv deleted the add-kimi-tests branch December 18, 2025 02:22
codego7250 pushed a commit to codego7250/TensorRT-LLM that referenced this pull request Dec 19, 2025
Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
yingguo-trt pushed a commit to yingguo-trt/TensorRT-LLM that referenced this pull request Dec 19, 2025
Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
lkomali pushed a commit to lkomali/TensorRT-LLM that referenced this pull request Dec 22, 2025
Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
Signed-off-by: lkomali <lkomali@nvidia.com>
JunyiXu-nv pushed a commit to JunyiXu-nv/TensorRT-LLM that referenced this pull request Dec 30, 2025
Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants