Skip to content

remove dead code in silu_and_mul kernel - creates output offsets (for 1D), expect n_elements param... but no need... #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hannahli-nv merged 3 commits into from
Dec 11, 2025
Merged

remove dead code in silu_and_mul kernel - creates output offsets (for 1D), expect n_elements param... but no need... #6

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7232608
Update silu_and_mul.py
lessw2020 Dec 10, 2025
26e8fdf
remove n_elements param
lessw2020 Dec 11, 2025
887d5c2
remove all n_elements references, verify working
lessw2020 Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/tilegym/ops/cutile/silu_and_mul.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ def silu_and_mul_kernel_row_wise(
input,
output,
TILE_SIZE: ConstInt,
n_elements: ConstInt,
hidden_size: ConstInt,
):
bid = ct.bid(0) # this gives us our row
Expand All @@ -45,7 +44,6 @@ def silu_and_mul_kernel_row_wise(
row_idx = bid
a_col_idx = offsets # First half: [0, hidden_size)
b_col_idx = offsets + hidden_size # Second half: [hidden_size, 2*hidden_size)
out_offsets = bid * hidden_size + offsets

# Load tiles using gather with 2D indices
# gather broadcasts (scalar, tile) to (tile,)
Expand Down Expand Up @@ -92,9 +90,6 @@ def silu_and_mul(
# Flatten input to 2D: (batch_size, 2 * hidden_size)
input_flat = input.view(-1, original_shape[-1])
batch_size = input_flat.shape[0]
n_elements = (
batch_size * hidden_size
) # Total elements to process in output

# Get final output shape
output_shape = list(original_shape)
Expand Down Expand Up @@ -126,7 +121,6 @@ def silu_and_mul(
input_flat,
output,
TILE_SIZE,
n_elements,
hidden_size
),
)
Expand Down