feat: swiglu simple math changes for perf upgrades#77
Merged
hannahli-nv merged 4 commits intoNVIDIA:mainfrom Mar 17, 2026
Merged
feat: swiglu simple math changes for perf upgrades#77hannahli-nv merged 4 commits intoNVIDIA:mainfrom
hannahli-nv merged 4 commits intoNVIDIA:mainfrom
Conversation
aghilann
commented
Mar 13, 2026
| sigmoid_a = 1.0 / (1.0 + ct.exp(-a_tile_f32)) | ||
| silu_a = a_tile_f32 * sigmoid_a | ||
| # Reuse shared helpers for consistent math path with forward. | ||
| sigmoid_a = sigmoid(a_tile_f32) |
Contributor
Author
There was a problem hiding this comment.
For such a small change, I choose not to move everything into experimental
Collaborator
|
/ok to test d18aaac |
hannahli-nv
reviewed
Mar 16, 2026
Co-authored-by: hannahli <165050866+hannahli-nv@users.noreply.github.com>
Collaborator
|
/ok to test baa63e7 |
hannahli-nv
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
swiglu-backward-hidden2048-float32
Avg Speedup: 1.02x
swiglu-backward-hidden4096-float32
Avg Speedup: 1.00x
swiglu-backward-hidden2048-bfloat16
Avg Speedup: 1.00x
swiglu-backward-hidden4096-bfloat16
Avg Speedup: 1.09x
Description
CI Configuration
Checklist
./format.sh)