Fix MOE tests#1476
Closed
ksivaman wants to merge 4 commits into
Closed
Conversation
Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
timmoon10
reviewed
Feb 11, 2025
| return _ReshapeFunc.apply(self, shape) | ||
|
|
||
| @classmethod | ||
| def to_float8( |
Member
There was a problem hiding this comment.
I prefer naming this quantize so that we can generalize to the other quantized tensor classes.
Member
Author
There was a problem hiding this comment.
This is meant as a standalone quantization for a high precision tensor and I think it would be better for this to not conflict with existing quantize function in QuantizedTensor.
ptrendx
requested changes
Feb 12, 2025
Member
ptrendx
left a comment
There was a problem hiding this comment.
Wait wait wait. Why are we adding the to_float8 function again? We should just fix the tests to create and use the quantizer instead.
Member
|
I think the |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The code drop for 2.0 results in breaking certain tests in the CI. This PR fixes the MOE/permutation tests.
Type of change
Checklist: