Skip to content

[PyTorch] Skip context parallelism tests if not enough GPUs#1508

Merged
timmoon10 merged 3 commits into
NVIDIA:mainfrom
timmoon10:debug-context-parallel-test
Feb 26, 2025
Merged

[PyTorch] Skip context parallelism tests if not enough GPUs#1508
timmoon10 merged 3 commits into
NVIDIA:mainfrom
timmoon10:debug-context-parallel-test

Conversation

@timmoon10
Copy link
Copy Markdown
Member

@timmoon10 timmoon10 commented Feb 25, 2025

Description

Some tests in test_fused_attn_with_cp.py require 4 GPUs and they fail on nodes with 2 GPUs. This PR only runs tests if there are enough available GPUs.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring
  • Testing

Changes

  • Skip context parallelism tests if not enough GPUs

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@timmoon10
Skip context parallelism tests if not enough GPUs
a83522c 
Signed-off-by: Tim Moon <tmoon@nvidia.com>
@timmoon10 timmoon10 added bug Something isn't working testing Improvements to tests or testing infrastructure 2.1.0 labels Feb 25, 2025
@timmoon10 timmoon10 requested a review from cyanguwa February 25, 2025 22:05
@timmoon10
Copy link
Copy Markdown
Member Author

timmoon10 commented Feb 25, 2025

/te-ci pytorch L1

cyanguwa
cyanguwa reviewed Feb 25, 2025
View reviewed changes
Comment thread tests/pytorch/fused_attn/test_fused_attn_with_cp.py Outdated
timmoon10
timmoon10 commented Feb 26, 2025
View reviewed changes
Comment thread tests/pytorch/fused_attn/test_fused_attn_with_cp.py Outdated
Comment thread tests/pytorch/fused_attn/test_fused_attn_with_cp.py Outdated
@timmoon10
Apply suggestions from code review
081a9f7 
Signed-off-by: Tim Moon <4406448+timmoon10@users.noreply.github.com>
@timmoon10
Merge branch 'main' into debug-context-parallel-test
8632ad0
@timmoon10 timmoon10 requested a review from cyanguwa February 26, 2025 01:48
@timmoon10
Copy link
Copy Markdown
Member Author

timmoon10 commented Feb 26, 2025

/te-ci pytorch L1

cyanguwa
cyanguwa approved these changes Feb 26, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@cyanguwa cyanguwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timmoon10 timmoon10 merged commit 2834e4a into NVIDIA:main Feb 26, 2025
timmoon10 added a commit that referenced this pull request Feb 26, 2025
@timmoon10
[PyTorch] Skip context parallelism tests if not enough GPUs (#1508)
867ab06 
* Skip context parallelism tests if not enough GPUs

Signed-off-by: Tim Moon <tmoon@nvidia.com>

* Apply suggestions from code review

Signed-off-by: Tim Moon <4406448+timmoon10@users.noreply.github.com>

---------

Signed-off-by: Tim Moon <tmoon@nvidia.com>
Signed-off-by: Tim Moon <4406448+timmoon10@users.noreply.github.com>
@hungryGeek16 hungryGeek16 mentioned this pull request May 31, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cyanguwa cyanguwa cyanguwa approved these changes

Assignees

No one assigned

Labels

2.1.0 bug Something isn't working testing Improvements to tests or testing infrastructure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@timmoon10 @cyanguwa