Ensure weight transpose is valid for Hopper FP8 training#1596
Merged
Conversation
Signed-off-by: Guyue Huang <guyueh@nvidia.com>
for more information, see https://pre-commit.ci
Contributor
Author
Signed-off-by: Guyue Huang <guyueh@nvidia.com>
Member
|
/te-ci pytorch L1 |
13 tasks
Contributor
Author
|
@timmoon10 I looked at one of the failed L0 test (unittest H100 1GPU) and it's failing for a module I didn't change (page attention). Is L0 ut expected to pass? |
KshitijLakhani
pushed a commit
that referenced
this pull request
Mar 24, 2025
* Update usage of weightmat before saving for backward Signed-off-by: Guyue Huang <guyueh@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix for layernorm mlp Signed-off-by: Guyue Huang <guyueh@nvidia.com> --------- Signed-off-by: Guyue Huang <guyueh@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Tim Moon <4406448+timmoon10@users.noreply.github.com>
lhb8125
pushed a commit
to lhb8125/TransformerEngine
that referenced
this pull request
Apr 8, 2025
* Update usage of weightmat before saving for backward Signed-off-by: Guyue Huang <guyueh@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix for layernorm mlp Signed-off-by: Guyue Huang <guyueh@nvidia.com> --------- Signed-off-by: Guyue Huang <guyueh@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Tim Moon <4406448+timmoon10@users.noreply.github.com>
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently for Hopper FP8 training, when weight is Float8Tensor and weight._transpose is invalidated by the optimizer step, no mechanism handles the creation of weight transpose thus the Dgrad errors out. This PR updates weight usage and ensure columnwise data is there before saved for bprop.
Fixes # (issue)
Type of change
Changes
Please list the changes introduced in this PR:
Checklist: