Skip to content

[JAX] Fixing importing in the encoder examples#1600

Merged
phu0ngng merged 3 commits into
NVIDIA:mainfrom
phu0ngng:fix_for_import
Mar 25, 2025
Merged

[JAX] Fixing importing in the encoder examples#1600
phu0ngng merged 3 commits into
NVIDIA:mainfrom
phu0ngng:fix_for_import

Conversation

@phu0ngng
Copy link
Copy Markdown
Collaborator

@phu0ngng phu0ngng commented Mar 21, 2025

Description

transformer_engine needs to be imported before transformer_enigne_jax.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@phu0ngng
import te before te_jax
9c69e5a 
Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>
@phu0ngng phu0ngng requested a review from ksivaman March 21, 2025 16:31
ksivaman
ksivaman approved these changes Mar 21, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@ksivaman ksivaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phu0ngng
Copy link
Copy Markdown
Collaborator Author

phu0ngng commented Mar 21, 2025

/te-ci jax L0

@KshitijLakhani KshitijLakhani self-requested a review March 21, 2025 23:06
@ksivaman
Copy link
Copy Markdown
Member

ksivaman commented Mar 24, 2025

/te-ci jax L0

ptrendx
ptrendx approved these changes Mar 24, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@ptrendx ptrendx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@phu0ngng phu0ngng merged commit 3dc8c6b into NVIDIA:main Mar 25, 2025
@phu0ngng phu0ngng deleted the fix_for_import branch March 25, 2025 14:23
KshitijLakhani pushed a commit that referenced this pull request Mar 25, 2025
@phu0ngng @KshitijLakhani
[JAX] Fixing importing in the encoder examples (#1600)
a5eb420 
import te before te_jax

Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>
lhb8125 pushed a commit to lhb8125/TransformerEngine that referenced this pull request Apr 8, 2025
@phu0ngng @lhb8125
[JAX] Fixing importing in the encoder examples (NVIDIA#1600)
85627eb 
import te before te_jax

Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>
@hungryGeek16 hungryGeek16 mentioned this pull request May 31, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ptrendx ptrendx ptrendx approved these changes

@KshitijLakhani KshitijLakhani KshitijLakhani approved these changes

@ksivaman ksivaman ksivaman approved these changes

Assignees

No one assigned

Labels

2.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@phu0ngng @ksivaman @ptrendx @KshitijLakhani @timmoon10