[JAX-Q] Distributed MXFP8 flax layer tests#1643
Merged
phu0ngng merged 2 commits intoNVIDIA:mainfrom Apr 4, 2025
Merged
Conversation
jberchtold-nvidia
force-pushed
the
dev/jberchtold/mxfp8-layer-test
branch
from
44e0d23 to
a9b5e95
Compare
Collaborator
Author
|
/te-ci L1 |
Signed-off-by: Jeremy Berchtold <jberchtold@nvidia.com>
jberchtold-nvidia
force-pushed
the
dev/jberchtold/mxfp8-layer-test
branch
from
a9b5e95 to
603b452
Compare
Collaborator
Author
|
/te-ci L1 |
phu0ngng
approved these changes
Apr 4, 2025
Collaborator
phu0ngng
left a comment
phu0ngng
left a comment
There was a problem hiding this comment.
LGTM!
Congrats on your "first" PR!
lhb8125
pushed a commit
to lhb8125/TransformerEngine
that referenced
this pull request
Apr 8, 2025
MXFP8 flax layer tests Signed-off-by: Jeremy Berchtold <jberchtold@nvidia.com>
wdykas
pushed a commit
to wdykas/TransformerEngine
that referenced
this pull request
Apr 14, 2025
MXFP8 flax layer tests Signed-off-by: Jeremy Berchtold <jberchtold@nvidia.com> Signed-off-by: Peter Dykas <wdykas@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue with the Flax layer axes so distributed MXFP8 layers work correctly and the distributed layer tests can be enabled.
Type of change
Changes
Please list the changes introduced in this PR:
transformer_engine/jax/flax/module.pytests/jax/test_distributed_layernorm_mlp.pyChecklist: