Skip to content

Removing NVTE_NO_SCALING #1650

Merged
phu0ngng merged 2 commits intoNVIDIA:mainfrom
phu0ngng:clean_no_scaling
Apr 7, 2025
Merged

Removing NVTE_NO_SCALING #1650
phu0ngng merged 2 commits intoNVIDIA:mainfrom
phu0ngng:clean_no_scaling

Conversation

@phu0ngng
Copy link
Collaborator

@phu0ngng phu0ngng commented Apr 7, 2025

Description

PR #1627 introduced NVTE_NO_SCALING; however, it is not yet supported in TE/Common.
Thus, this PR removes this scaling mode to avoid confusion for external developers.

Type of change

  • Documentation change (change only the documentation, either a fix or new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@phu0ngng
rm no scaling enum
58d8242 
Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>
@phu0ngng phu0ngng requested a review from ptrendx April 7, 2025 14:29
@phu0ngng
Copy link
Collaborator Author

phu0ngng commented Apr 7, 2025

/te-ci L0

@phu0ngng
update jax enum
32c8d24 
Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>
ksivaman
ksivaman approved these changes Apr 7, 2025
View reviewed changes
Copy link
Member

@ksivaman ksivaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phu0ngng phu0ngng merged commit b362a6e into NVIDIA:main Apr 7, 2025
11 checks passed
@phu0ngng phu0ngng deleted the clean_no_scaling branch April 7, 2025 17:30
wdykas pushed a commit to wdykas/TransformerEngine that referenced this pull request Apr 14, 2025
@phu0ngng @wdykas
Removing NVTE_NO_SCALING (NVIDIA#1650)
86d632d 
* rm no scaling enum

Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>

* update jax enum

Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>

---------

Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>
Signed-off-by: Peter Dykas <wdykas@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ksivaman ksivaman ksivaman approved these changes

@ptrendx ptrendx Awaiting requested review from ptrendx

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@phu0ngng @ksivaman