Add support for head_dim > 128#1797
Merged
cyanguwa merged 27 commits intoNVIDIA:mainfrom Jun 13, 2025
Merged
Conversation
Signed-off-by: Charlene Yang <charleney@nvidia.com>
Signed-off-by: Charlene Yang <charleney@nvidia.com>
for more information, see https://pre-commit.ci
Collaborator
Author
|
/te-ci |
Signed-off-by: Charlene Yang <charleney@nvidia.com>
Collaborator
Author
|
/te-ci |
Signed-off-by: Charlene Yang <charleney@nvidia.com>
Collaborator
Author
|
/te-ci |
Signed-off-by: Charlene Yang <8636796+cyanguwa@users.noreply.github.com>
Signed-off-by: Charlene Yang <charleney@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: Charlene Yang <charleney@nvidia.com>
Signed-off-by: Charlene Yang <charleney@nvidia.com>
Collaborator
Author
|
/te-ci L1 |
Signed-off-by: Charlene Yang <charleney@nvidia.com>
Collaborator
Author
|
/te-ci |
Signed-off-by: Charlene Yang <charleney@nvidia.com>
Signed-off-by: Charlene Yang <charleney@nvidia.com>
Signed-off-by: Charlene Yang <charleney@nvidia.com>
Collaborator
Author
|
/te-ci |
sudhakarsingh27
previously approved these changes
Jun 5, 2025
Collaborator
sudhakarsingh27
left a comment
sudhakarsingh27
left a comment
There was a problem hiding this comment.
Just a question but otherwise LGTM
Signed-off-by: Charlene Yang <charleney@nvidia.com>
Signed-off-by: Charlene Yang <charleney@nvidia.com>
Collaborator
Author
|
/te-ci |
Signed-off-by: Charlene Yang <charleney@nvidia.com>
Signed-off-by: Charlene Yang <charleney@nvidia.com>
Signed-off-by: Charlene Yang <charleney@nvidia.com>
This reverts commit 3e1b426. Signed-off-by: Charlene Yang <charleney@nvidia.com>
Collaborator
Author
|
/te-ci |
cyanguwa
requested review from
sudhakarsingh27
and removed request for
sudhakarsingh27
Signed-off-by: Charlene Yang <charleney@nvidia.com>
Collaborator
Author
|
/te-ci |
sudhakarsingh27
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for
head_dim > 128, fprop, all architecturesfrom cuDNN 9.10 and cudnn-frontend 1.12, andhead_dim_qk = 192, head_dim_v = 128, bprop, sm100from cuDNN 9.11 and cudnn-frontend 1.12.1.Type of change
Changes
Please list the changes introduced in this PR:
is_trainingtonvte_get_fused_attn_backend(breaking change)Checklist: