Add support for overlapping wgrad NCCL AG with dgrad GEMM#1849
Merged
timmoon10 merged 3 commits intoNVIDIA:mainfrom Jun 13, 2025
Merged
Add support for overlapping wgrad NCCL AG with dgrad GEMM#1849timmoon10 merged 3 commits intoNVIDIA:mainfrom
timmoon10 merged 3 commits intoNVIDIA:mainfrom
Conversation
djns99
force-pushed
the
djns99/mxfp8_naive_wgrad_overlap
branch
from
e48df51 to
8120e54
Compare
Collaborator
|
/te-ci pytorch L1 |
erhoo82
reviewed
Jun 6, 2025
djns99
force-pushed
the
djns99/mxfp8_naive_wgrad_overlap
branch
from
8120e54 to
a2382fd
Compare
Contributor
Author
|
/te-ci pytorch L1 |
1 similar comment
Collaborator
|
/te-ci pytorch L1 |
djns99
force-pushed
the
djns99/mxfp8_naive_wgrad_overlap
branch
2 times, most recently
from
6baa1e3 to
8b0d377
Compare
timmoon10
previously approved these changes
Jun 11, 2025
Signed-off-by: djns99 <40156487+djns99@users.noreply.github.com>
Signed-off-by: djns99 <40156487+djns99@users.noreply.github.com>
djns99
force-pushed
the
djns99/mxfp8_naive_wgrad_overlap
branch
from
bc49936 to
7e734f6
Compare
Signed-off-by: djns99 <40156487+djns99@users.noreply.github.com>
djns99
changed the title
timmoon10
approved these changes
Jun 11, 2025
Collaborator
|
/te-ci pytorch L1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for overlapping the wgrad All Gather operation with dgrad GEMM
Type of change
Changes
Checklist: