Manage dependencies and add missing einops req#1859
Merged
ksivaman merged 5 commits intoNVIDIA:mainfrom Jun 9, 2025
Merged
Conversation
Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
timmoon10
previously approved these changes
Jun 9, 2025
Collaborator
There was a problem hiding this comment.
LGTM, once we fix the build test issue.
Closes #1766. We no longer need to manually install einops in this build test:
Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Member
Author
|
/te-ci |
timmoon10
approved these changes
Jun 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently the test and install requirements for both frameworks are separately specified in 2 locations, the main
setup.pyand each of the frameworks' individualsetup.py. This may result in bugs such as in #1799 where thetransformerstest dep was not specified in the framework release build. Also add missingeinopsdep for pytorch.Fixes #1766
Type of change
Changes
einopsas TE/PyTorch install req.Checklist: