Skip to content

Manage dependencies and add missing einops req#1859

Merged
ksivaman merged 5 commits intoNVIDIA:mainfrom
ksivaman:manage_deps
Jun 9, 2025
Merged

Manage dependencies and add missing einops req#1859
ksivaman merged 5 commits intoNVIDIA:mainfrom
ksivaman:manage_deps

Conversation

@ksivaman
Copy link
Copy Markdown
Member

@ksivaman ksivaman commented Jun 7, 2025

Description

Currently the test and install requirements for both frameworks are separately specified in 2 locations, the main setup.py and each of the frameworks' individual setup.py. This may result in bugs such as in #1799 where the transformers test dep was not specified in the framework release build. Also add missing einops dep for pytorch.

Fixes #1766

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

  • Consolidate install and test requirements.
  • Add missing einops as TE/PyTorch install req.

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

ksivaman added 2 commits June 7, 2025 06:11
Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
timmoon10
timmoon10 previously approved these changes Jun 9, 2025
Copy link
Copy Markdown
Collaborator

@timmoon10 timmoon10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once we fix the build test issue.

Closes #1766. We no longer need to manually install einops in this build test:

run: pip install torch pybind11[global] einops

ksivaman added 2 commits June 9, 2025 11:10
Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
@ksivaman
Copy link
Copy Markdown
Member Author

ksivaman commented Jun 9, 2025

/te-ci

@ksivaman ksivaman merged commit ddcda1f into NVIDIA:main Jun 9, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

einops as undeclared dependency

2 participants