Skip to content

[PyTorch] Fix typo in GrouppedLinear#1867

Merged
pggPL merged 2 commits intoNVIDIA:mainfrom
pggPL:typo
Jun 12, 2025
Merged

[PyTorch] Fix typo in GrouppedLinear#1867
pggPL merged 2 commits intoNVIDIA:mainfrom
pggPL:typo

Conversation

@pggPL
Copy link
Copy Markdown
Collaborator

@pggPL pggPL commented Jun 11, 2025

Description

There is typo in groupped linear. When we change cpu offloading logic, we can get rid of this loop in all modules, so that's temporary fix.

Fixes #1833

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

pggPL and others added 2 commits June 11, 2025 09:06
Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
@pggPL
Copy link
Copy Markdown
Collaborator Author

pggPL commented Jun 11, 2025

/te-ci pytorch

Copy link
Copy Markdown
Collaborator

@timmoon10 timmoon10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

biases = saved_tensors[3 * N : 4 * N]
main_grads = ctx.main_grads

if ctx.cpu_offloading and ctx.fuse_wgrad_accumulation: # TOSO
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆

@pggPL pggPL merged commit c293d3a into NVIDIA:main Jun 12, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

seems typo here?

3 participants