Skip to content

[JAX] Distinguish the reasons why fp8 / mxfp8 is not supported in unit test#1873

Merged
huanghua1994 merged 1 commit intoNVIDIA:mainfrom
huanghua1994:fix-fp8-unsupport-reason
Jun 12, 2025
Merged

[JAX] Distinguish the reasons why fp8 / mxfp8 is not supported in unit test#1873
huanghua1994 merged 1 commit intoNVIDIA:mainfrom
huanghua1994:fix-fp8-unsupport-reason

Conversation

@huanghua1994
Copy link
Copy Markdown
Collaborator

Description

Distinguish the reasons why fp8 / mxfp8 is not supported in unit test. It's a little confusing to see "MXFP8 is not supported" for FP8 tests on A100.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

…ported

Signed-off-by: Hua Huang <huah@nvidia.com>
@huanghua1994 huanghua1994 requested a review from phu0ngng June 12, 2025 17:29
Copy link
Copy Markdown
Collaborator

@timmoon10 timmoon10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@phu0ngng
Copy link
Copy Markdown
Collaborator

/te-ci JAX L0

@huanghua1994 huanghua1994 merged commit 227961e into NVIDIA:main Jun 12, 2025
12 checks passed
@huanghua1994 huanghua1994 deleted the fix-fp8-unsupport-reason branch July 11, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants