Skip to content

[JAX] Use keyword args for jit in_shardings and out_shardings#1898

Merged
jberchtold-nvidia merged 2 commits intoNVIDIA:mainfrom
jberchtold-nvidia:dev/jberchtold/fix-jit-sharding-kwargs
Jun 26, 2025
Merged

[JAX] Use keyword args for jit in_shardings and out_shardings#1898
jberchtold-nvidia merged 2 commits intoNVIDIA:mainfrom
jberchtold-nvidia:dev/jberchtold/fix-jit-sharding-kwargs

Conversation

@jberchtold-nvidia
Copy link
Copy Markdown
Collaborator

Description

Switch to use keyword args for jax.jit(f, in_shardings=in_shardings, out_shardings=out_shardings) as position args are no longer supported in latest JAX versions.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

  • Use keyword args for jit sharding args

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@jberchtold-nvidia
Copy link
Copy Markdown
Collaborator Author

/te-ci L0

@phu0ngng phu0ngng self-requested a review June 26, 2025 16:43
@jberchtold-nvidia jberchtold-nvidia merged commit 5b16807 into NVIDIA:main Jun 26, 2025
36 of 38 checks passed
@jberchtold-nvidia jberchtold-nvidia deleted the dev/jberchtold/fix-jit-sharding-kwargs branch June 26, 2025 19:56
KshitijLakhani pushed a commit that referenced this pull request Jun 27, 2025
Use keyword args for jit in_shardings and out_shardings

Signed-off-by: Jeremy Berchtold <jberchtold@nvidia.com>
chtruong814 pushed a commit to chtruong814/TransformerEngine that referenced this pull request Jul 17, 2025
…#1898)

Use keyword args for jit in_shardings and out_shardings

Signed-off-by: Jeremy Berchtold <jberchtold@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants