Skip to content

Fix incorrect version checks for atomic GEMM #2095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
timmoon10 merged 3 commits into from
Aug 20, 2025
Merged

Fix incorrect version checks for atomic GEMM #2095

timmoon10 merged 3 commits into from
Aug 20, 2025

Conversation

@timmoon10
Copy link
Collaborator

@timmoon10 timmoon10 commented Aug 20, 2025

Description

#1938 mixed up the CUDA and cuBLAS version requirements.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

  • Fix incorrect version checks for atomic GEMM

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@timmoon10
Fix incorrect version checks for atomic GEMM
263e4f2 
Signed-off-by: Tim Moon <tmoon@nvidia.com>
@timmoon10 timmoon10 added bug Something isn't working 2.7.0 labels Aug 20, 2025
@timmoon10
Copy link
Collaborator Author

timmoon10 commented Aug 20, 2025

/te-ci

KshitijLakhani
KshitijLakhani previously approved these changes Aug 20, 2025
View reviewed changes
@timmoon10
Fix typo
0259b72 
Signed-off-by: Tim Moon <tmoon@nvidia.com>
@timmoon10 timmoon10 merged commit 406e2c9 into NVIDIA:main Aug 20, 2025
12 of 13 checks passed
@timmoon10 timmoon10 deleted the debug-gemm-version-checks branch August 20, 2025 22:24
pggPL pushed a commit to pggPL/TransformerEngine that referenced this pull request Aug 25, 2025
@timmoon10 @pre-commit-ci @pggPL
Fix incorrect version checks for atomic GEMM (NVIDIA#2095)
859773b 
* Fix incorrect version checks for atomic GEMM

Signed-off-by: Tim Moon <tmoon@nvidia.com>

* Fix typo

Signed-off-by: Tim Moon <tmoon@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Tim Moon <tmoon@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
pggPL pushed a commit to pggPL/TransformerEngine that referenced this pull request Aug 25, 2025
@timmoon10 @pre-commit-ci @pggPL
Fix incorrect version checks for atomic GEMM (NVIDIA#2095)
5f387d6 
* Fix incorrect version checks for atomic GEMM

Signed-off-by: Tim Moon <tmoon@nvidia.com>

* Fix typo

Signed-off-by: Tim Moon <tmoon@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Tim Moon <tmoon@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
KshitijLakhani pushed a commit that referenced this pull request Aug 26, 2025
@timmoon10 @pre-commit-ci @KshitijLakhani
Fix incorrect version checks for atomic GEMM (#2095)
3a4136b 
* Fix incorrect version checks for atomic GEMM

Signed-off-by: Tim Moon <tmoon@nvidia.com>

* Fix typo

Signed-off-by: Tim Moon <tmoon@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Tim Moon <tmoon@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
abhinavgoel95 pushed a commit to abhinavgoel95/TransformerEngine that referenced this pull request Sep 3, 2025
@timmoon10 @pre-commit-ci @phu0ngng
Fix incorrect version checks for atomic GEMM (NVIDIA#2095)
6b94bf5 
* Fix incorrect version checks for atomic GEMM

Signed-off-by: Tim Moon <tmoon@nvidia.com>

* Fix typo

Signed-off-by: Tim Moon <tmoon@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Tim Moon <tmoon@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KshitijLakhani KshitijLakhani KshitijLakhani left review comments

Assignees

No one assigned

Labels

2.7.0 bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@timmoon10 @KshitijLakhani