Revert "[Common] PDL for Quantization Kernels"#2114
Merged
jberchtold-nvidia merged 1 commit intomainfrom Aug 26, 2025
Merged
Conversation
This reverts commit bfab8c6. Signed-off-by: Jeremy Berchtold <jberchtold@nvidia.com>
jberchtold-nvidia
force-pushed
the
revert-2001-xiny/pdl_quantize
branch
from
d22880c to
5a885d7
Compare
Collaborator
Author
|
/te-ci L1 |
ptrendx
approved these changes
Aug 25, 2025
Collaborator
Author
|
/te-ci L1 |
Collaborator
Author
|
CI has same failures as main branch, so unrelated to this PR |
KshitijLakhani
pushed a commit
that referenced
this pull request
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #2001
This uses PDL unchecked which can cause issues in the case the surrounding kernels have data dependencies and use PDL
I've been able to trigger incorrect outputs by updating our activation to also use PDL and running unfused act+quant