[PyTorch] Disable Flash Attention backend in Userbuffers tests#2399
Merged
Conversation
Signed-off-by: Tim Moon <tmoon@nvidia.com>
Contributor
Greptile Summary
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Test as test_layers_with_overlap_*
participant Helper as _run_layer_with_overlap
participant Env as Environment
participant Subprocess as run_layer_with_overlap.py
Test->>Helper: Call with layer parameters
Helper->>Env: Set "NVTE_FLASH_ATTN=0"
Helper->>Env: Set "PYTORCH_JIT=0"
Helper->>Env: Set "NVTE_TORCH_COMPILE=0"
Helper->>Env: Set "NVTE_ALLOW_NONDETERMINISTIC_ALGO=0"
Helper->>Subprocess: Run test with modified environment
Subprocess-->>Helper: Return test result
Helper->>Env: Unset "NVTE_FLASH_ATTN"
Helper->>Env: Unset "PYTORCH_JIT"
Helper->>Env: Unset "NVTE_TORCH_COMPILE"
Helper->>Env: Unset "NVTE_ALLOW_NONDETERMINISTIC_ALGO"
Helper-->>Test: Return success/failure
|
Contributor
There was a problem hiding this comment.
1 file reviewed, no comments
Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format
Collaborator
Author
|
/te-ci pytorch L1 |
Contributor
There was a problem hiding this comment.
1 file reviewed, no comments
Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format
KshitijLakhani
approved these changes
Nov 18, 2025
14 tasks
KshitijLakhani
pushed a commit
that referenced
this pull request
Nov 20, 2025
Disable Flash attention in Userbuffers tests Signed-off-by: Tim Moon <tmoon@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We have experienced some Userbuffers test failures on A100s, apparently because the Flash Attention backward pass introduces numerical errors. This test is primarily intended to test the linear layers and not attention, so as a quick fix I've just disabled the Flash Attention backend.
Type of change
Changes
Checklist: