Deprecate unused APIs#321
Merged
Merged
Conversation
Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Member
Author
|
/te-ci |
timmoon10
requested changes
Jul 14, 2023
Collaborator
timmoon10
left a comment
timmoon10
left a comment
There was a problem hiding this comment.
We should only display the warning in the case the user tries to use these APIs. Also, I think exceptions are more appropriate than warnings since we are not going to be following the behavior expected by users.
Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Member
Author
|
@timmoon10 I agree that the exception makes more sense for when a |
timmoon10
approved these changes
Jul 14, 2023
Collaborator
timmoon10
left a comment
timmoon10
left a comment
There was a problem hiding this comment.
LGTM. My last nitpick is that we could mention in the warning message that skip_weight_param_allocation is not doing anything.
Member
Author
|
Pipeline 8976176 |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.