Update FindCUDNN.cmake for cuDNN 9#640
Merged
ksivaman merged 3 commits intoNVIDIA:mainfrom Jan 31, 2024
Merged
Conversation
Signed-off-by: Charlene Yang <8636796+cyanguwa@users.noreply.github.com>
timmoon10
approved these changes
Jan 30, 2024
Collaborator
timmoon10
left a comment
timmoon10
left a comment
There was a problem hiding this comment.
Overall LGTM.
For future reference, this is taken from https://github.com/NVIDIA/cudnn-frontend/blob/main/cmake/cuDNN.cmake.
Signed-off-by: Charlene Yang <8636796+cyanguwa@users.noreply.github.com>
Collaborator
Author
|
/te-ci |
Member
|
Hmm, is there a possibility for us to instead actually use the one shipped with cuDNN frontend rather than shipping with our own? |
ptrendx
pushed a commit
that referenced
this pull request
Feb 3, 2024
* update cudnn cmake for v9 Signed-off-by: Charlene Yang <8636796+cyanguwa@users.noreply.github.com> * add back license information Signed-off-by: Charlene Yang <8636796+cyanguwa@users.noreply.github.com> --------- Signed-off-by: Charlene Yang <8636796+cyanguwa@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.