Add tonemap renderer parameter #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of getting it scattering in multiple functions.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new tonemap renderer parameter (defaulting to true) that allows disabling internal tonemapping during sample accumulation. The change refactors the tonemapping logic to be conditional based on this parameter, fixing issue #56.
Key Changes
- Added
tonemapboolean parameter to renderer configuration with default valuetrue - Refactored
accumResultsfunction to conditionally apply tonemapping based on the parameter - Updated all renderer implementations to pass full
FrameGPUDatainstead of justFramebufferGPUData
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| visrtx_device.json | Added tonemap parameter definition to all renderer configurations |
| Renderer.h/.cpp | Added tonemap member variable, getter method, and parameter handling |
| gpu_objects.h | Added tonemap field to RendererGPUData structure |
| gpu_util.h | Refactored accumResults to conditionally apply tonemapping based on renderer parameter |
| *_ptx.cu files | Updated all accumResults calls to pass frameData instead of frameData.fb |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Copilot suggestion Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new renderer parameter (defaults to true), to possibly disable internal tonemapping.
Along with #160, this should fix #56