Fix build with CUDA 13 #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for CUDA 13 by conditionally linking against the CCCL (CUDA C++ Core Libraries) package when building with CUDA 13 or later. CUDA 13 requires explicit inclusion of CCCL as a separate dependency rather than bundling it with the CUDA Toolkit.
- Adds conditional detection and linking of CCCL for CUDA 13+
- Updates both root and core CMake configurations to handle the new dependency
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tsd/CMakeLists.txt | Adds CCCL package discovery for CUDA 13+ |
| tsd/src/tsd/core/CMakeLists.txt | Links CCCL target when available |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Confirmed working here: https://github.com/NVIDIA/VisRTX/actions/runs/19317846831/job/55252842971