fix(bundler): tolerate trailing slash on repoURL; quote Chart.yaml version

[yuanchen8911]

Summary

Follow-up to PR #1035 (merged at d638d009) addressing two non-blocking review nits from @mchmarny that weren't included in the squash:

1. injectValuesIntoSingleSource now pipes .Values.repoURL through trimSuffix "/" before appending /{{ .Chart.Name }}, so --set repoURL=oci://reg/org/ (easy copy-paste from a registry UI) renders as oci://reg/org/aicr-bundle instead of a silently-broken oci://reg/org//aicr-bundle.
2. TestWriteChartYAML_QuotesYAMLReservedScalarsAsName now takes an explicit (chartName, chartVersion) pair and exercises the version branch with "1.0" and "123" rows — proves the %q wrap on version is load-bearing (without it "1.0" reparses as the YAML float 1), not just cosmetic.

Motivation / Context

Mark's inline review on PR #1035 flagged both as non-blocking nits; they're small but worth the durability. The original #1035 was approved and merged before these landed, so they need a separate PR.

Fixes: N/A (cosmetic / defense-in-depth)
Related: #1034 (the bug #1035 fixed), #1035 (where the nits were raised)

Type of Change

• Bug fix (non-breaking change that fixes an issue)

Component(s) Affected

• Bundlers (pkg/bundler, pkg/component/*) — pkg/bundler/deployer/argocdhelm/argocdhelm.go

Implementation Notes

Nit 1 — trailing-slash robustness. Single one-line template change. Goldens (nodewright-customizations.yaml, gpu-operator-post.yaml) regenerated to reflect the new | trimSuffix "/" }}/{{ .Chart.Name }} shape.

Nit 2 — exercise the version branch. Restructured the table from (name, chartName, wantUnmarsh) (which assumed wantUnmarsh == chartName and hardcoded version "1.0.0") to (name, chartName, chartVersion) with the assertion checking each input round-trips back to its exact string via yaml.Unmarshal. Added two version-side rows ("1.0", "123").

Drive-by. Relaxed two pre-existing assertions in TestInjectValuesIntoSingleSource that hardcoded .Values.repoURL }} (the closing brace) to just .Values.repoURL so they survive the new trimSuffix pipeline insertion. The load-bearing intent — the directive references the caller's value — is preserved; the exact pipeline shape is documented elsewhere.

Testing

unset GITLAB_TOKEN ; make qualify
# All 22 chainsaw tests pass.
# Coverage: 76.9% > 75% floor.
# Vulnerability scan: clean.

GOFLAGS="-mod=vendor" go test ./pkg/bundler/deployer/argocdhelm/...
# ok

Risk Assessment

• Low — Single-line template change + test refactor. No behavioral change for clean --set repoURL values (existing renders pass through trimSuffix "/" unchanged); only operator-supplied trailing slashes are normalized. Bundles generated before this PR are unaffected; bundles generated after produce slightly more forgiving rendered output.

Rollout notes: None — the change is additive within the template pipeline and goldens.

Checklist

• Tests pass locally (make test with -race) — via make qualify
• Linter passes (make lint) — via make qualify
• I did not skip/disable tests to make CI green
• I added/updated tests for new functionality
• I updated docs if user-facing behavior changed — no user-facing surface change
• Changes follow existing patterns in the codebase
• Commits are cryptographically signed (git commit -S)

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 3f14a388-9b73-425c-a2a9-44294df48d15

📥 Commits

Reviewing files that changed from the base of the PR and between 1924c07 and 5d33800.

📒 Files selected for processing (2)

• pkg/bundler/deployer/argocdhelm/argocdhelm.go
• pkg/bundler/deployer/argocdhelm/argocdhelm_test.go

---

📝 Walkthrough

Walkthrough

This PR trims trailing slashes from user-supplied .Values.repoURL values in Helm templates for path-based child Applications. The core change adds trimSuffix "/" to .Values.repoURL before concatenating with /.Chart.Name in the injectValuesIntoSingleSource function's generated Helm template string. The same pattern is applied to two Helm template fixtures in testdata/. Unit tests are updated to match the revised template output, including loosened pattern matching for the repoURL assertion and expanded chart YAML roundtrip test cases with improved unmarshal failure diagnostics.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related issues

• argocd-helm OCI bundle: path-based child Applications miss .Chart.Name; Chart.yaml emits unquoted name #1034: Addresses the same path-based child Application repoURL construction issue by adding trimSuffix("/") before appending .Chart.Name to prevent malformed concatenations.

Possibly related PRs

• NVIDIA/aicr#1035: Modifies the same injectValuesIntoSingleSource Helm templating for spec.source.repoURL in path-based child applications, changing how {{ .Chart.Name }} is appended to .Values.repoURL.

Suggested labels

size/M

Suggested reviewers

• lockwobr
• mchmarny

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the two main changes: trailing slash handling for repoURL and version quoting in Chart.yaml.
Description check	✅ Passed	The description is detailed and directly related to the changeset, explaining both nits from PR #1035 review and their implementation.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}