Skip to content

fix: add nats storageClass for EKS dynamo deployment#107

Merged
mchmarny merged 8 commits intoNVIDIA:mainfrom
yuanchen8911:fix/dynamo-nats-storageclass
Feb 12, 2026
Merged

fix: add nats storageClass for EKS dynamo deployment#107
mchmarny merged 8 commits intoNVIDIA:mainfrom
yuanchen8911:fix/dynamo-nats-storageclass

Conversation

@yuanchen8911
Copy link
Contributor

Summary

  • The nats JetStream PVC was stuck Pending on EKS because the chart default storageClassName is empty and EKS has no default StorageClass
  • Add fileStore.pvc.storageClassName placeholder in dynamo-platform base values (required for the overlay merge system to work)
  • Set storageClassName: gp2 in the h100-eks-ubuntu-inference-dynamo overlay

Test plan

  • go test -race ./pkg/recipe/... — passes
  • Bundle generation includes storageClassName: gp2 in dynamo-platform values
  • Verified on EKS: nats PVC binds to gp2, nats pod Running (2/2)

🤖 Generated with Claude Code

@yuanchen8911 yuanchen8911 requested a review from a team as a code owner February 12, 2026 18:51
The nats JetStream PVC was stuck Pending on EKS because the chart
default storageClassName is empty and EKS has no default StorageClass.

- Add fileStore.pvc.storageClassName placeholder in dynamo-platform
  base values (required for overlay merge to work)
- Set storageClassName: gp2 in h100-eks-ubuntu-inference-dynamo overlay

Signed-off-by: Yuan Chen <yuanchen97@gmail.com>
@yuanchen8911 yuanchen8911 force-pushed the fix/dynamo-nats-storageclass branch from 7845152 to 15db144 Compare February 12, 2026 19:15
Copy link
Contributor

@coffeepac coffeepac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@mchmarny mchmarny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mchmarny mchmarny merged commit 49f5f83 into NVIDIA:main Feb 12, 2026
1 check passed
@mchmarny mchmarny deleted the fix/dynamo-nats-storageclass branch February 12, 2026 23:15
lockwobr pushed a commit that referenced this pull request Feb 12, 2026
Signed-off-by: Yuan Chen <yuanchen97@gmail.com>
Co-authored-by: Mark Chmarny <mchmarny@users.noreply.github.com>
lockwobr pushed a commit that referenced this pull request Feb 12, 2026
Signed-off-by: Yuan Chen <yuanchen97@gmail.com>
Co-authored-by: Mark Chmarny <mchmarny@users.noreply.github.com>
lockwobr pushed a commit that referenced this pull request Feb 12, 2026
Signed-off-by: Yuan Chen <yuanchen97@gmail.com>
Co-authored-by: Mark Chmarny <mchmarny@users.noreply.github.com>
lockwobr pushed a commit that referenced this pull request Feb 12, 2026
Signed-off-by: Yuan Chen <yuanchen97@gmail.com>
Co-authored-by: Mark Chmarny <mchmarny@users.noreply.github.com>
lockwobr pushed a commit that referenced this pull request Feb 12, 2026
Signed-off-by: Yuan Chen <yuanchen97@gmail.com>
Co-authored-by: Mark Chmarny <mchmarny@users.noreply.github.com>
lockwobr pushed a commit that referenced this pull request Feb 12, 2026
Signed-off-by: Yuan Chen <yuanchen97@gmail.com>
Co-authored-by: Mark Chmarny <mchmarny@users.noreply.github.com>
lockwobr pushed a commit that referenced this pull request Feb 13, 2026
Signed-off-by: Yuan Chen <yuanchen97@gmail.com>
Co-authored-by: Mark Chmarny <mchmarny@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants