docs: explain argocd-helm OCI credential matching#1070
Conversation
|
Welcome to AICR, @kiwigitops! Thanks for your first pull request. Before review, please ensure:
A maintainer will review this soon. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughUpdates docs/user/cli-reference.md for the aicr bundle --deployer argocd-helm section: clarifies that parent Applications append .Chart.Name into OCI source.repoURL while path-based child Applications append the chart name to the rendered source.repoURL (so including the chart in --set repoURL causes double-appending); adds a troubleshooting bullet explaining that for path-based OCI Applications Argo CD repo-server resolves sources as oci:////, and private registry credentials must be keyed to that rendered OCI prefix (or a broader permitted prefix) to avoid auth/fetch failures. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
🌿 Preview your docs: https://nvidia-preview-docs-argocd-oci-credentials.docs.buildwithfern.com/aicr |
|
@kiwigitops thanks for the doc update. |
d42b571 to
fdba133
Compare
|
Updated with a signed-off commit. I also rebased onto current |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/user/cli-reference.md`:
- Line 2489: Split the single dense troubleshooting paragraph titled "4.
**Private registry credentials keyed to a different source URL.**" into three
short paragraphs labeled Problem, Failure case, and Solution; keep the original
examples like `oci://<registry>/<path>/<chart>` and `--set repoURL` but make the
failure case explicit (Secret keyed only to `<registry>/<path>` or scheme-less
Helm-OCI URL causes Argo repo-server 401) and in the Solution paragraph show a
concrete example of a broader matching prefix (e.g., use `oci://<registry>/` or
`oci://<registry>/<path>/` as credential keys) and recommend choosing the
rendered `oci://.../<chart>` prefix or a cluster-allowed broader prefix.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: 0245a7f1-df22-4030-b2e4-dfc8ece28e06
📒 Files selected for processing (1)
docs/user/cli-reference.md
|
Actionable comments posted: 0 |
|
Updated the troubleshooting item into Problem / Failure case / Solution and kept the OCI credential-prefix examples. CodeRabbit is green on the follow-up commit, and the commits remain signed off. |
@kiwigitops still seeing "Commits must have verified signatures." This is |
yuanchen8911
left a comment
There was a problem hiding this comment.
/lgtm A couple of minor issues.
|
Please rebase. |
0c2beb9 to
5d45e98
Compare
|
Updated again. This is now rebased onto current
The PR diff is back to one file with 12 additions / 6 deletions. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/user/cli-reference.md`:
- Around line 2589-2593: Update the section intro that currently reads "Three
common causes, in order of likelihood:" (locate that exact phrase in the same
section as the new fourth item) so it no longer misstates the count—change it to
either "Four common causes:" or a future-proofed "Common causes:" to reflect the
added fourth item about OCI registry credential keys (the new item beginning
"Private registry credentials keyed to a different source URL.").
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: 2bf1dd0b-2382-47d6-998d-ae80ab57bd12
📒 Files selected for processing (1)
docs/user/cli-reference.md
5940120 to
1c82645
Compare
Signed-off-by: kiwigitops <kiwisclubco@gmail.com>
Summary
Related #1049.
Testing
git diff --check