chore(recipes): update nodewright to v0.17.1 (fixes immutable selector)#1502
Merged
Conversation
The v0.17.1 nodewright chart adds a selector-migration pre-upgrade hook (ServiceAccount + Role + Job) that deletes the stale, immutable-selector Deployment before upgrade, so helm upgrade recreates it cleanly across the skyhook->nodewright rename instead of failing on spec.selector. Bumps the pin in registry.yaml, base overlay, and example recipes, and regenerates the container-images BOM. Fixes #1382 Signed-off-by: Brian Lockwood <lockwobr@gmail.com>
lockwobr
added
dependencies
Contributor
|
🌿 Preview your docs: https://nvidia-preview-chore-nodewright-0-17-1.docs.buildwithfern.com/aicr |
Contributor
Recipe evidence check
Protected recipesRecipes with committed evidence (
Other affected recipes without evidence yet: 61These recipes are affected by this PR but carry no committed evidence pointer, so there is
How to refresh evidenceRun on a cluster matching the recipe's aicr snapshot -o snapshot.yaml
aicr validate \
-r recipes/overlays/<slug>.yaml \
-s snapshot.yaml \
--emit-attestation ./out \
--push ghcr.io/<your-fork>/aicr-evidence
# Copy to the per-source path printed in the emit 'copyTo' hint:
# recipes/evidence/<slug>/<source>/<bundle-digest>.yamlThis gate is warning-only and never blocks merge. See ADR-007 for the trust model. |
Contributor
Coverage Report ✅
Coverage BadgeNo Go source files changed in this PR. |
mchmarny
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bump the
nodewright-operatorHelm chart pin fromv0.17.0tov0.17.1across the registry, base overlay, and example recipes, and regenerate the container-images BOM.Motivation / Context
deploy.shcould not upgradenodewright-operatorover a pre-rename install: the chart's controller-manager Deployment has an immutablespec.selectorthat changed across the skyhook to nodewright rename, sohelm upgradefailed withfield is immutableand the retry loop could not recover (manualkubectl deletewas required).The
v0.17.1chart fixes this upstream by shipping aselector-migrationpre-upgrade hook (ServiceAccount + Role + Job,hook-weight: -10) that deletes the stale Deployment before the upgrade sohelm upgraderecreates it cleanly. AICR's generatedinstall.shrunshelm upgrade --installwith no--no-hooks, so the hook executes as part of the normal deploy.Fixes: #1382
Related: #1361
Type of Change
Component(s) Affected
pkg/recipe)docs/,examples/)Implementation Notes
v0.17.1is a chart-only patch: itsappVersionis stillv0.17.0, so the rendered operator image legitimately remainsghcr.io/nvidia/nodewright/operator:v0.17.0. The regenerated BOM reflects this.*-ocpentries from Add OpenShift Container Platform (OCP) as a service type #1380 that were never regenerated). These are zero-image manifest entries and harmless.Testing
make qualifypassed: 23 chainsaw tests passed / 0 failed, golangci-lint + yamllint clean, Grype found no vulnerabilities, license headers OK. No Go source changed, so the coverage gate does not apply.Risk Assessment
Rollout notes: Patch chart upgrade; the new pre-upgrade hook recovers stuck pre-rename installs automatically. Backwards compatible.
Checklist
make testwith-race)make lint)git commit -S)