ci(pages): pin custom domain via CNAME in Pages artifact#1508
Merged
Conversation
The evidence dashboard publishes to GitHub Pages via the Actions source, where the custom domain (validation.aicr.run) is stored in repo settings. A deploy whose artifact omits a CNAME file can silently clear that setting, flapping the domain off the live site. Write _site/CNAME on every build so the domain is reasserted on each publish and becomes self-healing. The step runs after the determinism diff so the extra file cannot trip the byte-identical reproducibility gate. Signed-off-by: Mark Chmarny <mark@chmarny.com>
mchmarny
added
the
theme/ci-dx
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
Coverage Report ✅
Coverage BadgeNo Go source files changed in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Write a
CNAMEfile into the GitHub Pages artifact so the evidence dashboard's custom domain (validation.aicr.run) is reasserted on every publish.Motivation / Context
The evidence dashboard (
evidence-dashboard-publish.yaml, GP5 / #1405) deploys to GitHub Pages using the GitHub Actions source. In that mode the custom domain is stored in repo settings, but a deploy whose artifact omits aCNAMEfile can silently clear that setting — flapping the domain off the live site and forcing a manual re-add + DNS re-check. Writing the file on each build makes the domain self-healing.Discovered while bringing
validation.aicr.runonline: DNS was correct but the artifact carried noCNAME, leaving the custom-domain state dependent solely on the settings value.Fixes: N/A
Related: #1405
Type of Change
Component(s) Affected
.github/workflows/evidence-dashboard-publish.yaml(GitHub Pages deploy)Implementation Notes
diff -r _site _site_check) so the extraCNAMEfile cannot trip the byte-identical reproducibility gate.validation.aicr.run), matching the repo's preference for explicit, self-documenting values in workflows.Testing
yamllint .github/workflows/evidence-dashboard-publish.yaml # cleanWorkflow-only change (one added step); no Go sources touched, so the test/coverage and e2e/scan portions of
make qualifyare not applicable. Fullmake qualifyequivalent runs in CI.Risk Assessment
Rollout notes: Takes effect on the next publish to
main. No migration; if reverted, the domain simply reverts to relying on the settings value.Checklist
make testwith-race) — N/A (no Go changes)yamllintclean)git commit -S)