Skip to content

docs(agents): correct coverage floor to 75% (matches .settings.yaml)#1552

Merged
mchmarny merged 1 commit into
NVIDIA:mainfrom
yuanchen8911:docs/agent-rules-coverage-floor
Jun 30, 2026
Merged

docs(agents): correct coverage floor to 75% (matches .settings.yaml)#1552
mchmarny merged 1 commit into
NVIDIA:mainfrom
yuanchen8911:docs/agent-rules-coverage-floor

Conversation

@yuanchen8911

Copy link
Copy Markdown
Contributor

Summary

.claude/CLAUDE.md (and its CI-synced AGENTS.md mirror) stated the test-coverage gate enforces a 70% floor. The enforced value is 75%: make test-coverage reads quality.coverage_threshold: '75' from .settings.yaml via yq (Makefile:19); the 70 at Makefile:21 is only a fallback when that read returns empty.

Fixes the line in both files (line 584) from 70% → 75%.

Type of Change

  • Documentation update

Testing

make check-agents-sync   # OK (CLAUDE.md and AGENTS.md mirror in sync)

Doc-only change to the agent-rules files; check-agents-sync confirms the mirror stays consistent.

Checklist

  • Changes follow existing patterns
  • Commit is signed (-S -s)

The agent-rules files said the test-coverage gate enforces a 70% floor, but
.settings.yaml sets quality.coverage_threshold: '75' and make test-coverage
reads it via yq (the Makefile's 70 is only a fallback when that read is empty).
Fix .claude/CLAUDE.md and its CI-synced AGENTS.md mirror.

Signed-off-by: Yuan Chen <yuanchen97@gmail.com>
@yuanchen8911 yuanchen8911 requested a review from a team as a code owner June 29, 2026 23:47
@yuanchen8911 yuanchen8911 added the theme/ci-dx CI pipelines, developer experience, and build tooling label Jun 29, 2026
@yuanchen8911 yuanchen8911 requested a review from mchmarny June 29, 2026 23:48
@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: cab7fccd-83bb-4806-8967-863a46388404

📥 Commits

Reviewing files that changed from the base of the PR and between 3eb13ff and 8d5406c.

📒 Files selected for processing (2)
  • .claude/CLAUDE.md
  • AGENTS.md

📝 Walkthrough

Walkthrough

Two documentation files (AGENTS.md and .claude/CLAUDE.md) each have a single line updated: the project-wide test coverage floor enforced by make test-coverage is changed from 70% to 75%. No code, logic, or other documentation sections are modified.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the docs-only change and the corrected 75% coverage floor.
Description check ✅ Passed The description matches the changeset and explains the 70% to 75% documentation correction.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@mchmarny mchmarny merged commit 77c6b6d into NVIDIA:main Jun 30, 2026
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/docs size/XS theme/ci-dx CI pipelines, developer experience, and build tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants