docs(agents): correct coverage floor to 75% (matches .settings.yaml)#1552
Merged
mchmarny merged 1 commit intoJun 30, 2026
Merged
Conversation
The agent-rules files said the test-coverage gate enforces a 70% floor, but .settings.yaml sets quality.coverage_threshold: '75' and make test-coverage reads it via yq (the Makefile's 70 is only a fallback when that read is empty). Fix .claude/CLAUDE.md and its CI-synced AGENTS.md mirror. Signed-off-by: Yuan Chen <yuanchen97@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughTwo documentation files ( Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
mchmarny
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.claude/CLAUDE.md(and its CI-syncedAGENTS.mdmirror) stated the test-coverage gate enforces a 70% floor. The enforced value is 75%:make test-coveragereadsquality.coverage_threshold: '75'from.settings.yamlviayq(Makefile:19); the70at Makefile:21 is only a fallback when that read returns empty.Fixes the line in both files (line 584) from 70% → 75%.
Type of Change
Testing
Doc-only change to the agent-rules files;
check-agents-syncconfirms the mirror stays consistent.Checklist
-S -s)