fix: pass cluster K8s version to Helm SDK chart rendering#197
Merged
Conversation
The Helm Go SDK defaults to Kubernetes v1.20.0 in client-only mode (chartutil.DefaultCapabilities). Charts with kubeVersion constraints (cert-manager >= 1.22, skyhook-operator >= 1.30, etc.) fail rendering because the SDK never learns the actual cluster version. Extract the K8s server version from the snapshot and pass it via install.KubeVersion so the SDK uses the real cluster version for constraint evaluation.
dims
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
install.KubeVersionduring chart renderingchart requires kubeVersion: >= X which is incompatible with Kubernetes v1.20.0errors in validationRoot cause
PR #186 replaced the
helmCLI subprocess with the Helm Go SDK for chart rendering. In client-only mode, the SDK copieschartutil.DefaultCapabilitieswhich hardcodesk8sVersionMajor=1, k8sVersionMinor=20(Kubernetes v1.20.0). Theinstall.KubeVersionoverride was never set, so charts withkubeVersionconstraints (cert-manager, network-operator, skyhook-operator, etc.) fail rendering.Fix
kubeVersionparameter toresolveExpectedResources()andrenderHelmTemplate()kubeVersionFromSnapshot()helper extracts the version from the K8s server subtypeinstall.KubeVersionviachartutil.ParseKubeVersion()beforeRunWithContext()Test plan
go test -race ./pkg/validator/...— all tests passmake test— full suite passesmake lint— 0 issues