fix(e2e): update deploy-agent test for current snapshot CLI#198
Merged
fix(e2e): update deploy-agent test for current snapshot CLI#198
Conversation
The snapshot command always deploys an agent Job — the --deploy-agent flag was removed in a prior refactoring. Update E2E test to verify agent-related flags (--namespace, --image, --node-selector, etc.) instead of checking for the removed --deploy-agent flag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_deploy_agent_clito match current snapshot CLI which always deploys an agent Job (no--deploy-agenttoggle)--namespace,--image,--node-selector,--toleration,--timeout,--cleanup) exist in help outputRoot cause
The
--deploy-agentflag was removed in a prior snapshot CLI refactoring. The E2E test still checked for it insnapshot --helpoutput, causingcli/deploy-agent/help: --deploy-agent not in help outputfailure.Note on second E2E failure
The
snapshot/deploy-agent: Job did not completefailure is environmental — the fake nvidia-smi Job in the Kind cluster fails independently. That's an infrastructure issue, not a code bug.Test plan
bash -n tests/e2e/run.sh— syntax validaicr snapshot --helpoutput matches new test assertions