ci: use copy-pr-bot branch pattern for PR workflows#30
Merged
dims merged 1 commit intoNVIDIA:mainfrom Feb 3, 2026
Merged
Conversation
Update workflows to trigger on push to `pull-request/[0-9]+` branches instead of `pull_request` events. This aligns with copy-pr-bot which creates these branches for secure PR testing. Changes: - on-push.yaml: Replace pull_request trigger with copy-pr-bot pattern - codeql.yaml: Replace pull_request trigger with copy-pr-bot pattern - verify-licenses.yaml: Replace pull_request trigger with copy-pr-bot pattern This matches the pattern used by nvsentinel and prevents untrusted PR code from accessing secrets or self-hosted runners. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: Davanum Srinivas <dsrinivas@nvidia.com>
Collaborator
Author
|
/ok to test 1344334 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update workflows to trigger on push to
pull-request/[0-9]+branches instead ofpull_requestevents. This aligns with copy-pr-bot which creates these branches for secure PR testing.Summary
Replace
pull_requesttriggers withpushtopull-request/[0-9]+branches to enable copy-pr-bot workflow.Motivation / Context
The repo has copy-pr-bot configured (
.github/copy-pr-bot.yamlmerged in #28), but workflows were still usingpull_requesttriggers. This prevents the bot from working as intended.With this change:
pull-request/Nbranches/ok to test <SHA>This matches the pattern used by nvsentinel. See:
Fixes: N/A
Related: #28
Type of Change
Component(s) Affected
cmd/eidos,pkg/cli)cmd/eidosd,pkg/api,pkg/server)pkg/recipe)pkg/bundler,pkg/component/*)pkg/collector,pkg/snapshotter)pkg/validator)pkg/errors,pkg/k8s)docs/,examples/).github/workflows/)Implementation Notes
Updated workflows:
on-push.yaml- Main CI qualificationcodeql.yaml- Security scanningverify-licenses.yaml- License verificationChange pattern:
Testing
The changes are identical to the pattern used in nvsentinel which is working in production.
Risk Assessment
Rollout notes: N/A - CI changes only. After merge, new PRs will trigger via copy-pr-bot branches instead of PR events.
Checklist
make testwith-race)make lint)git commit -s) — DCO info