feat: add fullnameOverride to remove release prefix from deployment names#32
Merged
mchmarny merged 5 commits intoNVIDIA:mainfrom Feb 3, 2026
Merged
Conversation
…e names Add fullnameOverride to component values to generate cleaner resource names without the umbrella chart release name prefix (eidos-stack-). Changes: - kube-prometheus-stack: fullnameOverride: kube-prometheus - grafana: fullnameOverride: grafana - kube-state-metrics: fullnameOverride: kube-state-metrics - gpu-operator: fullnameOverride: gpu-operator - node-feature-discovery: fullnameOverride: node-feature-discovery - cert-manager: fullnameOverride: cert-manager - network-operator: operator.fullnameOverride: network-operator - nvsentinel: fullnameOverride: nvsentinel - skyhook-operator: fullnameOverride: skyhook-operator - nvidia-dra-driver-gpu: fullnameOverride: nvidia-dra-driver-gpu - prometheus-adapter: Updated prometheus URL to match new naming Before: eidos-stack-kube-prometheus-prometheus After: kube-prometheus-prometheus Known limitations: - prometheus-adapter: fullnameOverride pending upstream PR prometheus-community/helm-charts#6584 - skyhook-operator: may need upstream chart fix for fullnameOverride Signed-off-by: Yuan Chen <yuanchen97@gmail.com> chore: retrigger CI
Coverage Report ✅
Coverage BadgeNo Go source files changed in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fullnameOverrideto component values to generate cleaner resource names without the umbrella chart release name prefix (eidos-stack-)fullnameOverridefor nested components (grafana, kube-state-metrics, node-feature-discovery)Motivation
When deploying the eidos umbrella chart with release name
eidos-stack, all resources get prefixed witheidos-stack-, resulting in verbose names likeeidos-stack-kube-prometheus-prometheus. This change removes the prefix for cleaner, more intuitive resource names.Changes
eidos-stack-kube-prometheus-*kube-prometheus-*eidos-stack-grafanagrafanaeidos-stack-kube-state-metricskube-state-metricsgpu-operatorgpu-operatoreidos-stack-node-feature-discovery-*node-feature-discovery-*eidos-stack-cert-managercert-managereidos-stack-network-operatornetwork-operatoreidos-stack-nvsentinelnvsentinelnvidia-dra-driver-gpu-*nvidia-dra-driver-gpu-*eidos-stack-skyhook-operatorskyhook-operatorKnown Limitations
fullnameOverridenot yet supported upstream. PR submitted: chore(prometheus-adapter): add nameOverride and fullnameOverride values prometheus-community/helm-charts#6584eidos-stack-skyhook-operator-controller-managerTest plan
make test)eidos-stack-prefix🤖 Generated with Claude Code