Skip to content

feat: skyhook, split customizations to their own component and add training#58

Merged
mchmarny merged 4 commits intomainfrom
skyhook-training-eks2
Feb 5, 2026
Merged

feat: skyhook, split customizations to their own component and add training#58
mchmarny merged 4 commits intomainfrom
skyhook-training-eks2

Conversation

@ayuskauskas
Copy link
Contributor

Summary

  • Skyhook, split customizations off from operator component.
  • Operator now targets system and customizations target accelerated
  • Add customization for h100 training

Motivation / Context

Improves how management of customizations by letting each be their own manifest. And allows independent versioning of operator and customizations.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Refactoring (no functional changes)
  • Build/CI/tooling

Component(s) Affected

  • CLI (cmd/eidos, pkg/cli)
  • API server (cmd/eidosd, pkg/api, pkg/server)
  • Recipe engine / data (pkg/recipe)
  • Bundlers (pkg/bundler, pkg/component/*)
  • Collectors / snapshotter (pkg/collector, pkg/snapshotter)
  • Validator (pkg/validator)
  • Core libraries (pkg/errors, pkg/k8s)
  • Docs/examples (docs/, examples/)
  • Other: ____________

Testing

# Commands run (prefer `make qualify` for non-trivial changes)
make qualify

Checked recipe and bundles rendered correctly with passed in selectors and tolerations

Risk Assessment

  • Low — Isolated change, well-tested, easy to revert
  • Medium — Touches multiple components or has broader impact
  • High — Breaking change, affects critical paths, or complex rollout

Rollout notes:

Checklist

  • Tests pass locally (make test with -race)
  • Linter passes (make lint)
  • I did not skip/disable tests to make CI green
  • I added/updated tests for new functionality
  • I updated docs if user-facing behavior changed
  • Changes follow existing patterns in the codebase
  • Commits are signed off (git commit -s) — DCO info

@ayuskauskas ayuskauskas requested review from a team as code owners February 5, 2026 00:33
Copy link
Member

@mchmarny mchmarny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mchmarny mchmarny added the enhancement New feature or request label Feb 5, 2026
@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Coverage Report ✅

Metric Value
Coverage 73.0%
Threshold 70%
Status Pass
Coverage Badge
![Coverage](https://img.shields.io/badge/coverage-73.0%25-green)

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/eidos/pkg/bundler/deployer/helm 56.59% (-6.50%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/eidos/pkg/bundler/deployer/helm/helm.go 56.59% (-6.50%) 258 (+25) 146 (-1) 112 (+26) 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@mchmarny mchmarny enabled auto-merge (squash) February 5, 2026 11:37
@mchmarny mchmarny merged commit 80a9329 into main Feb 5, 2026
12 of 16 checks passed
@mchmarny mchmarny deleted the skyhook-training-eks2 branch February 5, 2026 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants